Closed
Bug 336839
Opened 18 years ago
Closed 18 years ago
"Link from other application" pref name in Tabs prefPane sounds very awkward
Categories
(Camino Graveyard :: Preferences, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Camino1.5
People
(Reporter: alqahira, Assigned: froodian)
References
Details
(Keywords: fixed1.8.1)
Attachments
(2 files, 2 obsolete files)
|
10.81 KB,
application/zip
|
alqahira
:
review+
mikepinkerton
:
superreview+
|
Details |
|
65.76 KB,
image/png
|
Details |
Screenshot
The Tabs prefPane has some pref names singular and some plural; at least one of the singular ones ("Link from other application") sounds really odd.
We should switch
Link from other application --> Links from other applications
Opens in a new window --> Open in new windows
Opens in a new tab in the frontmost window --> Open in new tabs in the frontmost window
Reuses the frontmost window --> Reuse the frontmost window
This breaks the parallelism with "Command click on link" (for hyperlinks internal to Camino), but I think that's OK here since the current pref name is so awkward, even just in relation to the other pref names in that pane.
|
Assignee | |
Comment 1•18 years ago
|
||
Taking. I'm gonna wait on bug 184994 to do this though, so there's only one nib change for the prefpane. (any other open bugs to change the tabs prefpane?)
Assignee: nobody → stridey
|
|
Assignee | |
Comment 2•18 years ago
|
||
Attachment #227322 -
Flags: review?(alqahira)
|
|
Assignee | |
Comment 3•18 years ago
|
||
|
|
Assignee | |
Comment 4•18 years ago
|
||
Refined on IRC
Attachment #227322 -
Attachment is obsolete: true
Attachment #227372 -
Flags: review?(alqahira)
Attachment #227322 -
Flags: review?(alqahira)
|
|
Assignee | |
Comment 5•18 years ago
|
||
Attachment #227323 -
Attachment is obsolete: true
|
Reporter | |
Updated•18 years ago
|
Attachment #227372 -
Flags: review?(alqahira) → review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #227372 -
Flags: superreview?(mikepinkerton)
|
||
Comment 6•18 years ago
|
||
Comment on attachment 227372 [details]
New Tabs.nib
looks ok to me. sr=pink
Attachment #227372 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [needs checkin]
|
||
Comment 7•18 years ago
|
||
Fixed, checked in trunk and branch
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in
before you can comment on or make changes to this bug.
Description
•