337041 - feeds failes rendering if the rss item doesn't have summary

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

See this rss.
http://www.d-toybox.com/studio/weblog/show.php?mode=rss&ver=2.0

Fx cannot render all items in the RSS file.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0 (-w)

Comment 3

[:Gavin Sharp [email: [e-mail]]]

You could just use |if (summary && summary.length > MAX_CHARS)|

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #3)
> You could just use |if (summary && summary.length > MAX_CHARS)|

yeah, but the creating text node is not needed if the summary is null.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

oh, this is fixed by bug 336903.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=subscribe.js&branch=&root=/cvsroot&subdir=mozilla/browser/components/feeds/content&command=DIFF_FRAMESET&rev1=1.6&rev2=1.7