337244 - Incorrect pointer passed in nsUnicodeToISO2022JP::ConvertNoBuffNoErr

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[timeless]

[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvja] > rm nsUnicodeToISO2022JP.o; make -s ; patch -d ../../../../intl/uconv/ucvja -p0 < ../../../../intl/uconv/ucvja/0 ; make -s; patch -d ../../../../intl/uconv/ucvja -R -p0 < ../../../../intl/uconv/ucvja/0 nsUnicodeToISO2022JP.cpp
/home/timeless/build-tree/mozilla-cvs-20060424/intl/uconv/ucvja/nsUnicodeToISO2022JP.cpp: In member function `virtual nsresult nsUnicodeToISO2022JP::ConvertNoBuffNoErr(const PRUnichar*, PRInt32*, char*, PRInt32*)':
/home/timeless/build-tree/mozilla-cvs-20060424/intl/uconv/ucvja/nsUnicodeToISO2022JP.cpp:201: warning: cast from `const PRUint16*' to `const PRUint16**' increases required alignment of target type
/home/timeless/build-tree/mozilla-cvs-20060424/intl/uconv/ucvja/nsUnicodeToISO2022JP.cpp:220: warning: cast from `const PRUint16*' to `const PRUint16**' increases required alignment of target type
patching file nsUnicodeToISO2022JP.cpp
patching file nsUnicodeToISO2022JP.cpp
[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvja] >

Comment 1

[timeless]

Attachment: pass something that seems closer to the right kind of pointer

Comment 2

[timeless]

Attachment: pass something that seems closer to the right kind of pointer

[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvja] > rm nsUnicodeToJISx0201.o ; make -s; patch -d ../../../../intl/uconv/ucvja -p0 < ../../../../intl/uconv/ucvja/1; make -s ; patch -d ../../../../intl/uconv/ucvja -R -p0 < ../../../../intl/uconv/ucvja/1
nsUnicodeToJISx0201.cpp
/home/timeless/auto_build/projects.maemo.org/mozilla/trunk/maemo-browser-mozilla-engine/build-tree/mozilla-cvs-20060424/intl/uconv/ucvja/nsUnicodeToJISx0201.cpp: In function `nsresult nsUnicodeToJISx0201Constructor(nsISupports*, const nsIID&, void**)':
/home/timeless/auto_build/projects.maemo.org/mozilla/trunk/maemo-browser-mozilla-engine/build-tree/mozilla-cvs-20060424/intl/uconv/ucvja/nsUnicodeToJISx0201.cpp:53: warning: cast from `const PRUint16*' to `const PRUint16**' increases required alignment of target type
patching file nsUnicodeToJISx0201.cpp
patching file nsUnicodeToJISx0201.cpp
[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvja] >

Comment 3

[timeless]

smontagu asked about 3 other files, the reason i didn't include them is that they aren't being built so i didn't see warnings in my log file :)

[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvja] > make nsUnicodeToJISx0212.o
nsUnicodeToJISx0212.cpp
c++ -o nsUnicodeToJISx0212.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET  -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\" -DBUILD_ID=0000000000 -I/home/timeless/auto_build/build-tree/mozilla/intl/uconv/ucvja/../util -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/uconv -I../../../dist/include/pref -I../../../dist/include   -I../../../dist/include/ucvja -I../../../dist/include/nspr    -I../../../dist/sdk/include -I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -ffunction-sections -march=armv5t -mthumb -O2 -g0 -fno-unit-at-a-time  -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsUnicodeToJISx0212.pp /home/timeless/build-tree/mozilla/intl/uconv/ucvja/nsUnicodeToJISx0212.cpp
/home/timeless/build-tree/mozilla/intl/uconv/ucvja/nsUnicodeToJISx0212.cpp: In function `nsresult nsUnicodeToJISx0212Constructor(nsISupports*, const nsIID&, void**)':
/home/timeless/build-tree/mozilla/intl/uconv/ucvja/nsUnicodeToJISx0212.cpp:55: warning: cast from `const PRUint16*' to `const PRUint16**' increases required alignment of target type
[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvja] > make nsUnicodeToJISx0208.o
nsUnicodeToJISx0208.cpp
c++ -o nsUnicodeToJISx0208.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET  -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\" -DBUILD_ID=0000000000 -I/home/timeless/build-tree/mozilla/intl/uconv/ucvja/../util -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/uconv -I../../../dist/include/pref -I../../../dist/include   -I../../../dist/include/ucvja -I../../../dist/include/nspr    -I../../../dist/sdk/include -I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -ffunction-sections -march=armv5t -mthumb -O2 -g0 -fno-unit-at-a-time  -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsUnicodeToJISx0208.pp /home/timeless/build-tree/mozilla/intl/uconv/ucvja/nsUnicodeToJISx0208.cpp
/home/timeless/build-tree/mozilla/intl/uconv/ucvja/nsUnicodeToJISx0208.cpp: In function `nsresult nsUnicodeToJISx0208Constructor(nsISupports*, const nsIID&, void**)':
/home/timeless/build-tree/mozilla/intl/uconv/ucvja/nsUnicodeToJISx0208.cpp:55: warning: cast from `const PRUint16*' to `const PRUint16**' increases required alignment of target type
[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvja] > cd ../ucvko/
[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvko] > make nsUnicodeToKSC5601.o
nsUnicodeToKSC5601.cpp
c++ -o nsUnicodeToKSC5601.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET  -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\" -DBUILD_ID=0000000000 -I/home/timeless/build-tree/mozilla/intl/uconv/ucvko/../util -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/uconv -I../../../dist/include   -I../../../dist/include/ucvko -I../../../dist/include/nspr    -I../../../dist/sdk/include -I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -ffunction-sections -march=armv5t -mthumb -O2 -g0 -fno-unit-at-a-time  -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsUnicodeToKSC5601.pp /home/timeless/build-tree/mozilla/intl/uconv/ucvko/nsUnicodeToKSC5601.cpp
/home/timeless/build-tree/mozilla/intl/uconv/ucvko/nsUnicodeToKSC5601.cpp: In function `nsresult nsUnicodeToKSC5601Constructor(nsISupports*, const nsIID&, void**)':
/home/timeless/build-tree/mozilla/intl/uconv/ucvko/nsUnicodeToKSC5601.cpp:56: warning: cast from `const PRUint16*' to `const PRUint16**' increases required alignment of target type
[sbox-arm: ~/build-tree/mozilla/opt-arm-unknown-linux-gnu/intl/uconv/ucvko] >

Comment 4

[timeless]

Attachment: different patch

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 221425 [details] [diff] [review]
pass something that seems closer to the right kind of pointer

I'm fairly sure that this change is correct, with the addition of changing from g0201ShiftTable to &g0201ShiftTable, and the same with the other 3 files I mentioned (http://lxr.mozilla.org/seamonkey/search?string=%28umappingtable*%29+g)

I don't know how to test it, though.

Comment 6

[timeless]

Comment on attachment 221427 [details] [diff] [review]
different patch

mozilla/intl/uconv/public/uconvutil.h 	1.20