337558 - nsXULAppRunner needs updating after bug 214672: remove nsIZipEntry

Status: VERIFIED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Alfred Kayser]

nsXULAppRunner needs updating after bug 214672: 
findEntries now returns a UTF8StringEnumerator so that GetNext no longer returns a nsIZipEntry but a entry name string. Also replace "*" with null (no pattern match). Patch following real soon!

Comment 1

[Alfred Kayser]

Attachment: Patch to update XULAppRunnerSetup after bug 214672

Robert, this code needs a little update after bug 214672.
Can you review this? Thanks in advance!

Comment 2

[Alfred Kayser]

Comment on attachment 221673 [details] [diff] [review]
Patch to update XULAppRunnerSetup after bug 214672

Requesting review (somehow the previous request got cancelled...)

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 221673 [details] [diff] [review]
Patch to update XULAppRunnerSetup after bug 214672

Looks good

Comment 4

[Alfred Kayser]

Comment on attachment 221673 [details] [diff] [review]
Patch to update XULAppRunnerSetup after bug 214672

Darin, a small followup to bug 214672. Can you do the SR and checkin? Thanks in advance.

Comment 5

[Alfred Kayser]

*** Bug 342488 has been marked as a duplicate of this bug. ***

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Alfred, do you need someone to check this in?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I went ahead and landed this because of bug 342488 comment 3.
mozilla/xulrunner/setup/nsXULAppInstall.js 	1.5

Comment 8

[Alfred Kayser]

Thanks!

Comment 9

[Tuukka Tolvanen (sp3000)]

Comment on attachment 221673 [details] [diff] [review]
Patch to update XULAppRunnerSetup after bug 214672

>   _installZipEntry : function ze_installZipEntry(aZipReader, aZipEntry,
>                                                  aDestination) {
>     var file = aDestination.clone();
> 
>-    var path = aZipEntry.name;
>-    var dirs = path.split(/\//);
>+    var dirs = aZipEntry.split(/\//);
>     var isDirectory = path.match(/\/$/) != null;
                        ^^^^
oops

Comment 10

[Tuukka Tolvanen (sp3000)]

> oops
->  bug 362686