Closed Bug 338000 Opened 18 years ago Closed 18 years ago

Bottom bevel of toolbar above content missing with no tabs

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: tuukka.tolvanen, Assigned: bugzilla-mozilla-20000923)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

before/after
87.07 KB, image/png
Details
Override toolbar CSS only for XP_WIN
1.78 KB, patch
mconnor
: review+
Details | Diff | Splinter Review 
Bottom bevel of toolbar above web page content missing with no browser tabs open. regression from bug 336847.
Attached image before/after — 
toolkit=cairo-gtk. gtk theme is clearlooks
This is because Firefox is sharing winstripe files between OSes, which sucks. Time for crappy ifdefs.
Assignee: nobody → silver
Status: NEW → ASSIGNED
Attached patch ifdef XP_WIN the code *sigh* (obsolete) — — Splinter Review 
This also changes the way the line is removed to work around the Gecko bug 337859.
Attachment #222046 - Flags: review?(bugs)
Comment on attachment 222046 [details] [diff] [review]
ifdef XP_WIN the code *sigh*

*sigh* This of course doesn't actually work, unlike the -1px margin which did...
Attachment #222046 - Attachment is obsolete: true
Attachment #222046 - Flags: review?(bugs)
This patch plays nicely with the native theming (that's coming soon) and only applies to Windows. The moz-collapsed bit *is* a nasty evil hack, but then so is the entire of this bit of CSS.
Flags: blocking1.9a2?
Attachment #222168 - Flags: review?(mconnor)
Comment on attachment 222168 [details] [diff] [review]
Override toolbar CSS only for XP_WIN

This is blocking continued work on native themes. If I don't get something from this by 2006-06-19 I'm stopping this bloody game.
Attachment #222168 - Flags: review?(mconnor) → review+
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: blocking1.9a2?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: