Closed Bug 338045 Opened 18 years ago Closed 18 years ago

safe browsing slows down page load in non-enhanced mode

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: tony, Assigned: tony)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

We spend a considerable amount of time processing the url on page load.  We don't need to do that upfront, so we should defer until later.
Attached patch v1: defer local list check (obsolete) — Splinter Review
Use a G_Alarm to defer the local list lookup until after docnavstart.

Also break a JS circular reference between MultiTableQuerier and the callback.

Start to refactor the code included in browser.xul to be namespaced in a single object.
Attachment #222091 - Flags: review?(brettw)
Attachment #222091 - Flags: approval-branch-1.8.1?
Attachment #222091 - Flags: approval-branch-1.8.1? → approval-branch-1.8.1?(bryner)
Same as the last patch except we remove some abstraction layers (move webprogresslistener directly into phishing warden and get rid of EventRegistrar).
Attachment #222091 - Attachment is obsolete: true
Attachment #222116 - Flags: review?(brettw)
Attachment #222116 - Flags: approval-branch-1.8.1?(bryner)
Attachment #222091 - Flags: review?(brettw)
Attachment #222091 - Flags: approval-branch-1.8.1?(bryner)
Attachment #222116 - Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1+
Attachment #222116 - Flags: review?(brettw) → review+
tweak web progress listener to listen for only document requests rather than all requests
Fixed on trunk and 1.8 branch.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.