338064 - browser.formfill.enable = false, disables search suggest

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060515 Minefield/3.0a1 ID:2006051512 [cairo]

repro:
1. go to about:config and set browser.formfill.enable to false
2. type anything in the searchbar (use Yahoo or Google)

result:
suggest is disabled

Comment 1

[Peter van der Woude [:Peter6]]

same problem on 1.8.1 branch of course

Comment 2

[pal-moz]

"set browser.formfill.enable to false" is same as
tools>Options>Privacy "Saved Forms"
uncheck "Save information..."

Comment 3

[Régis Caspar]

As I said in http://forums.mozillazine.org/viewtopic.php?p=2266185, suggestion wasn't working here (with browser.formfill.enable = true). I changed <SuggestionURL>http://www.google.com/complete/search?csv=t&amp;qu=</SuggestionURL>
to <SuggestionURL><![CDATA[http://www.google.com/complete/search?csv=t&qu=]]></SuggestionURL>
into google.xml (and made similar changes into yahoo.xml) and now it works.

Comment 4

[Peter van der Woude [:Peter6]]

I think it is fundamentally wrong that a user is forced to store his formfill data if he wishes to use suggest.

Comment 5

[Joe Hughes]

This seems to be the relevant code that's causing this:
http://lxr.mozilla.org/mozilla1.8/source/browser/base/content/browser.js#1228

This is because the search suggestions are implemented using the same autocomplete interface that the form history uses.

Comment 6

[Mike Connor [:mconnor]]

+ for now until we decide what we're doing here.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

*** Bug 340225 has been marked as a duplicate of this bug. ***

Comment 8

[Joe Hughes]

Attachment: Disables search history (but preserves suggestions) when form history is disabled

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 225086 [details] [diff] [review]
Disables search history (but preserves suggestions) when form history is disabled

So I was a little bit confused as to why this fixes this bug, but I realized that it works because both nsFormHistory::AddEntry (called to save text in form history after it is entered) and nsFormHistory::AutoCompleteSearch (called to get autocomplete entries from form history when building the popup) already check formfill.enabled and behave accordingly. This means that you can also remove the attribute check at:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/search/content/search.xml&rev=1.67&mark=393#392

r=me with that.

Comment 10

[Joe Hughes]

Attachment: Updated to add tweak Gavin suggested

Comment 11

[Joe Hughes]

Landed on branch & trunk.

Comment 12

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060615 Minefield/3.0a1 ID:2006061515

verified fixed on trunk

Comment 13

[Worcester12345]

FYI, as a resource:

http://www.loconet.ca/
GSuggest extension