338447 - zlib should be linked explicit, at least when specifying a custom one

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[ause]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060411
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060411

a couple of binaries is linking zlib implicit, thus ignoring the settings of --with-system-zlib=<some-path>

Reproducible: Always

Steps to Reproduce:
1.use --with-system-zlib=<some_path> with configure or .mozconfig
2.place a zlib there where you will notice a difference (a damaged one should do for testing purpose ;))
3.

Actual Results:  
this lib is ignored in several places (e.g. mozilla/toolkit/mozapps/update/src/updater/Makefile.in)

Expected Results:  
link that zlib (or fail in the given example)

Comment 1

[ause]

Attachment: add zlib to link line

Comment 2

[Scott MacGregor]

Comment on attachment 222516 [details] [diff] [review]
add zlib to link line

I'm not the right person to review this build config change. I'd suggest starting with bsmedberg.

Also this bug isn't related to Thunderbird, I'd suggest moving it to Mozilla Build Config.

Thanks for the patch!

Comment 3

[ause]

moving as suggested

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

-> Core

Comment 5

[Benjamin Smedberg]

Comment on attachment 222516 [details] [diff] [review]
add zlib to link line

Why does embedding/browser/gtk/tests need to link explicitly against zlib? That doesn't sound right to me.

Comment 6

[ause]

looks like in embedding/browser/gtk/tests libz.so comes in by libpng12.so and libfontconfig.so.
but no matter who pulls it in, "--with-system-zlib=some_path" simply gets ignore on linking when linking zlib implicit.
i've no problem to tweak my environment using the right one ;). but offering this setting and ignore it afterwards doesn't sound right to me...

same goes for internal zlib functionality if i didn't get something wrong.

Comment 7

[Benjamin Smedberg]

(In reply to comment #6)
> looks like in embedding/browser/gtk/tests libz.so comes in by libpng12.so and
> libfontconfig.so.
> but no matter who pulls it in, "--with-system-zlib=some_path" simply gets
> ignore on linking when linking zlib implicit.

--with-system-zlib=path should only affect mozilla's explicit linkage of zlib. When libpng/libfontconfig pick up zlib implicitly that's none of our business.

Comment 8

[ause]

i think it is when the build is breaking because of taking the system zlib instead of the specified one...

Comment 9

[Benjamin Smedberg]

"not our problem"... if a non-standard zlib is in play, pkgconfig, LD_LIBRARY_PATH or your LDFLAGS are going to have to make sure that everything is consistent.

Comment 10

[ause]

LD_LIBRARY_PATH won't help much on link time and implicit linked libraries are  looked up ignoring the "-L" switches passed to the linker.
there might be other ways to tweak the linker but linking implicit makes it harder without a reason visible to me.

Comment 11

[cls]

As I pointed out in bug 325758 comment 16, it is the builder's responsibility to make sure that the out-of-tree libraries being used have the correct dependencies.  The --with-system-zlib and other library options apply only to mozilla's explicit use of the library.

If libfontconfig & libpng are linked to the system version of zlib, instead of your special version, then you need to rebuild libfontconfig & libpng against the special version.