Closed Bug 338503 Opened 18 years ago Closed 18 years ago

In-line spell check is broken [OS locale problem]

Categories

(Core :: Spelling checker, defect)

Product:
Core
Component:
Spelling checker
Version:
1.8 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bugmozz, Unassigned)

Details

(Keywords: regression) 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060518 BonEcho/2.0a2 ID:2006051819

Most words except a number are checked as misspelling.
Suggestion words are not listed.

[screen shot]
051805 : http://img230.imageshack.us/img230/1280/0518051jy.jpg
051816 : http://img66.imageshack.us/img66/7194/0518167sp.jpg

[range]
2006051805-2006051816
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-05-18+05%3A00%3A00&maxdate=2006-05-18+17%3A00%3A00&cvsroot=%2Fcvsroot
Component: Search → General
Keywords: regression
QA Contact: search → general
Summary: [regression] Search Suggestions is borken. → In-line spell check is broken
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060518 Minefield/3.0a1 ID:2006051818 [cairo]

same with Minefield

[range]
2006051807-2006051818
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-05-18+07%3A00%3A00&maxdate=2006-05-18+18%3A00%3A00&cvsroot=%2Fcvsroot
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060518 Minefield/3.0a1 ID:2006051822 [cairo]

I am not seeing this with a trunk build (WFM)
Extensionrelated ?
WFM both on latest trunk and branch, WinXP. Have you chosen the right language (if you have multiple languages installed)?
(In reply to comment #2)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060518
> Minefield/3.0a1 ID:2006051822 [cairo]
> 
> I am not seeing this with a trunk build (WFM)
> Extensionrelated ?
> 

new prof with talkback/DOMi
http://img132.imageshack.us/img132/1514/spell9um.jpg

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060518 Minefield/3.0a1 ID:2006051822 [cairo]
(In reply to comment #3)
> WFM both on latest trunk and branch, WinXP. Have you chosen the right language
> (if you have multiple languages installed)?
> 

Minefield/Bon Echo : en-US
spellchecking : default, no addition/change.
Win XP HOME (JAPANESE ver.)
OS locale vs Firefox locale problem ?
(In reply to comment #4)
> (In reply to comment #2)
> > Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060518
> > Minefield/3.0a1 ID:2006051822 [cairo]
> > 
> > I am not seeing this with a trunk build (WFM)
> > Extensionrelated ?
> > 
> 
> new prof with talkback/DOMi
> http://img132.imageshack.us/img132/1514/spell9um.jpg
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060518
> Minefield/3.0a1 ID:2006051822 [cairo]
> 

Weird...
can I e-mail you some builds so you can narrow down the regression on trunk ?
I have:
firefox-3.0a1.en-US.win32_20060518_0914_cairo.zip (nightly)
firefox-3.0a1.en-US.win32_20060518_1118_cairo.zip
firefox-3.0a1.en-US.win32_20060518_1327_cairo.zip
(In reply to comment #6)
> Weird...
> can I e-mail you some builds so you can narrow down the regression on trunk ?
> I have:
> firefox-3.0a1.en-US.win32_20060518_0914_cairo.zip (nightly)
> firefox-3.0a1.en-US.win32_20060518_1118_cairo.zip
> firefox-3.0a1.en-US.win32_20060518_1327_cairo.zip
> 

thanks.
send me 1118 and 1327 one by one, please.
checked on 1118 and 1327.
both are same, problem happened.

[regression range on Minefield]
051807-051810
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1147963560&maxdate=1147973579
I'd be tempted to say this regressed from mkaply's checkin
Summary: In-line spell check is broken → In-line spell check is broken [OS locale problem]
Component: General → Spelling checker
Product: Firefox → Core
Version: unspecified → 1.8 Branch
Mike Kaply's checkin could not have caused this (CCK isn't built with Firefox), and Brendan's is unlikely as well. Are you sure that regression range is correct?
(In reply to comment #10)
> Mike Kaply's checkin could not have caused this (CCK isn't built with Firefox),
> and Brendan's is unlikely as well. Are you sure that regression range is
> correct?
> 

sure.
http://img72.imageshack.us/img72/8302/spellcheck9sn.jpg
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060519 BonEcho/2.0a2 ID:2006051904

work again with Branch Nightly.
checkin between 051819 and 051904
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=AviarySuiteBranchTinderbox&branch=MOZILLA_1_8_BRANCH&date=explicit&mindate=1148005080&maxdate=1148010299

I will test with Trunk Nightly later
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060519 Minefield/3.0a1 ID:2006051905 [cairo]

work again too.

Thank you for all of you.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
What patch fixed it?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It's resolved/worksforme if you can't point at a patch that fixed this
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.