338609 - Old url redirect does not handle vid's correctly

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Cameron]

Spawning this of the fix for Bug 332843. 
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=628&vid=11803 doesn't redirect correctly, because "vid" matches ".*id"

Note that https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&vid=11803&id=628 redirects fine, but while I'm not sure about how the old site constructed urls (if it put the vid or the id first), we should just fix this for the sake of goodness - if anyone had modified their urls or whatever, it would a pretty finicky bug.

Comment 1

[Cameron]

Trev: seeing as bug 337198 was wontfixed, could you fix this separately please? 

Comment 2

[Wladimir Palant]

Attachment: Make sure only id is accepted as paramter name

Comment 3

[Michael Morgan [:morgamic]]

Comment on attachment 236801 [details] [diff] [review]
Make sure only id is accepted as paramter name

Shaver, since you would be the one to approve this eventually, could you review this for Wladimir?

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

How should we test this?  htaccess changes scare me...

(Also: do we still need to concern ourselves with these old URL forms?  If they've been broken since May or earlier, I'm tempted to just leave it be!)

Comment 5

[Wladimir Palant]

I forgot about that bug. Anyway, it is fixed in Remora.