339032 - Safebrowsing: 'Get me out of here' should go to the default home page

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, enhancement, P1)

Description

[u88484]

When you come upon a phishy site, the 'Get me out of here' link should do something different. Throwing out some ideas here:

- Take you to www.google.com or www.mozilla.com if only one tab open
- close the tab and focus on tab you came from if more then one tab open
- Take you back as if the back button was hit
   - if you didn't come from anywhere (ex opened the link in a new tab) close the tab
     - if that was the only tab open then load google.com or www.mozilla.com
- Would say load the homepage but for people that have multiple that would open a few tabs which would be annoying. (currently something like this happens but only the first tab is loaded with the same text as in the tools->options->general->'location(s)' shows)

Hmm too many ifs. Guess you should just be taken to google.com or mozilla.com

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Why are google.com or mozilla.com more relevant than your homepage?

I do think it would be a good idea to just close the tab if the load was in a new tab and there is no session history.

Comment 2

[u88484]

(In reply to comment #1)
> Why are google.com or mozilla.com more relevant than your homepage?
> 

Was just throwing out ideas based on thats what happens now but with a bug with people with multiple homepages.

> I do think it would be a good idea to just close the tab if the load was in a
> new tab and there is no session history.
> 
Thats what I would like to see but figured it'd make things too complicated with coding for :
- What if only one tab open?
- What if more then one tab open? Focus tab you came from, tab on left? 
- What if no session history?

Comment 3

[Simon Bünzli]

I'm not sure how loading the homepage is useful when you hit a phishing site. Why not (1) close tabs with the phishing site being the only entry (as Gavin suggested, but making sure that at least a blank tab remains in the window) and (2) navigate back in history otherwise (where you came from, probably the most relevant page, and you won't risk any dataloss through a closed tab)?

Alternatives coming to mind:
* Just blank the page (replacing the page with about:blank)
* Reword "Get me out of here" to "Close this tab" (though a rewording would probably be in order anyway)

Comment 4

[u88484]

I think a blank tab would leave the user with a blank stare at the screen. Also, 'Get me out of here' sounds great, no need to change that.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

It should really take the user to the localized Firefox Start page.

Comment 6

[u88484]

Mike, I believe your bug will take care of this so marking this one as the dupe.

*** This bug has been marked as a duplicate of 343084 ***

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Actually, it doesn't, but it still should. We can make that change after beta1.

Comment 8

[u88484]

(In reply to comment #7)
> Actually, it doesn't, but it still should. We can make that change after beta1.
> 

ah ok, I thought that the "point to mozilla.com anti-phishing FAQ pages" part of the bug was covering this. sorry about that

Comment 9

[Bill Gianopoulos [:WG9s]]

(In reply to comment #3)
> I'm not sure how loading the homepage is useful when you hit a phishing site.
> Why not (1) close tabs with the phishing site being the only entry (as Gavin
> suggested, but making sure that at least a blank tab remains in the window) and
> (2) navigate back in history otherwise (where you came from, probably the most
> relevant page, and you won't risk any dataloss through a closed tab)?
> 
> Alternatives coming to mind:
> * Just blank the page (replacing the page with about:blank)
> * Reword "Get me out of here" to "Close this tab" (though a rewording would
> probably be in order anyway)
> 

good choices but order is incorrect.

Navigate back if possible should be the first choice.

Then comes what to do if the back history is empty.  If multiple tabs/windows are open then a close seems correct.  Then the case for a single window with a single tab open and no back history becomes the only condition for which something arbitrary needs to be done.

Comment 10

[Worcester12345]

(In reply to comment #5)
> It should really take the user to the localized Firefox Start page.
> 

Actually, it should just throw up a message like "This will close the window (or tab) you are in and restart the browser with the remaining tabs open." and then do that. 

Comment 11

[Mike Connor [:mconnor]]

beltzner, what are we doing with this?

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

It should go to Firefox Start.

Comment 13

[Mike Connor [:mconnor]]

Firefox Start? or your homepage?

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Sorry, I'll be clearer:

 - if there's back history, go back one page
 - if not, then
     - if there's no other tabs open, go to Firefox Start
     - if there are other tabs open, close the offending tab

But if all that's too complicated or adds too many cases for us to be QAing at this late stage, then just always go to Firefox Start and be done with it.

Comment 15

[Mike Connor [:mconnor]]

Moving out to Fx3

Comment 16

[aero]

I agree with Mike Beltzer. However, if you're going to push this back to Firefox 3, you still can't keep the current behaviour because it is bugged. See: https://bugzilla.mozilla.org/show_bug.cgi?id=344029

Comment 17

[Jackie Liu]

I would go for the "Take you back as if the back button was hit
   - if you didn't come from anywhere (ex opened the link in a new tab) close
the tab"

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

After talking with Gavin, and despite feeling that some optimizations could exist for this behaviour based on the premise that the vast majority of phishing links come from email links out of web or desktop apps, we both feel that a single, dependable, always predictable outcome is the best option here.

So "Get me out of here" ---> Firefox Start

Comment 19

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Go to the default home page (which is Firefox Start for builds with official branding), per comment 18.

Comment 20

[Mike Connor [:mconnor]]

Comment on attachment 235446 [details] [diff] [review]
patch

shazam!

Comment 21

[:Gavin Sharp [email: [e-mail]]]

browser/components/safebrowsing/content/phishing-afterload-displayer.js 1.13

Comment 22

[Mike Schroepfer]

Comment on attachment 235446 [details] [diff] [review]
patch

a=schrep/beltnzer for drivers.

Comment 23

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/safebrowsing/content/phishing-afterload-displayer.js 	1.1.2.12

Comment 24

[Carsten Book [:Tomcat]]

Verified during Testruns on 1.8.1.1 on Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1