Closed Bug 339196 Opened 18 years ago Closed 18 years ago

Cleaner wizard image for NSIS installer

Categories

(Firefox :: Installer, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 2 beta1

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

(Keywords: fixed1.8.1)

Attachments

(9 obsolete files)

I threw the original image together in a minute for the trunk and have since cleaned it up. New image coming up shortly.
Attached image new image (obsolete) —
Mike, the image I checked in was done in a rush and I'd like to land this cleaned up version on the trunk. I used the png on the Minefield welcome page to create it.
Attachment #223272 - Flags: ui-review?(beltzner)
Attached image screenshots - before and after (obsolete) —
Screenshots of before and after so you can compare the change.
Filed Bug 339204 for the garbled BMP-image (at least on my computer). 
Comment on attachment 223272 [details]
new image

This looks a little bit downsampled to me. Let's do this right, and get Steven to deliver us a quick graphic.
Attachment #223272 - Flags: ui-review?(beltzner) → ui-review-
Steven - can you generate some new BMP images for the NSIS installer? We'd be looking for three, I think:

 - using Minefield logo
 - using Bon Echo/unbranded logo
 - using Firefox logo

Thanks.
Here's a cleaner installer graphic for Minefield. I'm not sure what the format/dimensions requiremetns are for the NSIS installer - let me know if anything else/different is needed.
Attachment #223272 - Attachment is obsolete: true
Assignee: robert.bugzilla → steven
Attached image official image (checked in) (obsolete) —
Attachment #223273 - Attachment is obsolete: true
Attachment #223464 - Flags: ui-review?(steven)
Attachment #223464 - Flags: ui-review?(steven) → ui-review+
Attached image sample header (obsolete) —
Steven, could you create two more images that are 150px width by 57px height along the lines of the attachment for the wizard header for official, trunk, and branch?
Attached image branch image (checked in) (obsolete) —
Attachment #223466 - Flags: ui-review?(steven)
(In reply to comment #8)
> Steven, could you create two more images that are 150px width by 57px height
> along the lines of the attachment for the wizard header for official, trunk,
> and branch?

Yup. What are the color/alpha limitations. Are we able to have something with full alpha-transparency? I noticed another bug about how this installer header doesn't match if the system colors are off-white.
Attachment #223466 - Flags: ui-review?(steven) → ui-review+
Attachment #223312 - Attachment description: Cleaner Minefield install graphic → Cleaner Minefield install graphic (checked in)
Attachment #223312 - Attachment is obsolete: true
Comment on attachment 223464 [details]
official image (checked in)

Mike, need this on the branch.
Attachment #223464 - Flags: approval-branch-1.8.1?(mconnor)
Comment on attachment 223466 [details]
branch image (checked in)

and this one too.
Attachment #223466 - Flags: approval-branch-1.8.1?(mconnor)
Checked in the left watermark wizard images to trunk. I'll post the image color/alpha limitations for Steven as soon as I find them.
Steven, the control used is the standard Static control with the SS_BITMAP style. I've never tried to get them to support alpha transparency and don't know if it is possible. Unless I am mistaken the bug about the header you are referring to involves using high contrast and isn't affected by the header image since the image doesn't cover the entire header (e.g. it isn't used for the background of the text with NSIS).
Robert - thanks for looking into that. The bug I had in mind was bug #267829 - any thoughts on that?
Status: NEW → ASSIGNED
Attachment #223466 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Attachment #223464 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Steven - NSIS forces a white background for the entire header. I just checked out a couple of msi setups from MS and they do the same thing so I think that it is acceptable to do this. There is at least one high contrast bug as well.
Attachment #223464 - Attachment description: official image → official image (checked in)
Attachment #223464 - Attachment is obsolete: true
Attachment #223466 - Attachment description: branch image → branch image (checked in)
Attachment #223466 - Attachment is obsolete: true
Attached image official header (checked in) (obsolete) —
I used the mozicon128 and reduced its size for the header... not sure if it is acceptable but I had some time to do the header images.
Attachment #223758 - Flags: review?(steven)
Attached image branch (checked in) (obsolete) —
Attachment #223760 - Flags: review?(steven)
Attached image trunk (checked in) (obsolete) —
Attachment #223761 - Flags: review?(steven)
Attachment #223465 - Attachment is obsolete: true
Attachment #223758 - Flags: review?(steven) → review+
Attachment #223760 - Flags: review?(steven) → review+
Attachment #223761 - Flags: review?(steven) → review+
These look fine Robert. Thanks.
Attachment #223758 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #223760 - Flags: approval-branch-1.8.1?(mconnor)
Assignee: steven → robert.bugzilla
Status: ASSIGNED → NEW
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #223758 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Attachment #223760 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Attachment #223761 - Attachment description: trunk → trunk (checked in)
Attachment #223758 - Attachment description: official header → official header (checked in)
Attachment #223758 - Attachment is obsolete: true
Attachment #223760 - Attachment description: branch → branch (checked in)
Attachment #223760 - Attachment is obsolete: true
Attachment #223761 - Attachment is obsolete: true
Keywords: fixed1.8.1
Target Milestone: --- → Firefox 2 beta1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: