Closed Bug 339258 Opened 18 years ago Closed 18 years ago

Dynamically update provider menupopup

Categories

(Toolkit :: Safe Browsing, defect, P1)

Product:
Toolkit
Component:
Safe Browsing
Version:
2.0 Branch
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 340677
Milestone:
Firefox 2 beta1

People

(Reporter: rflint, Assigned: rflint)

References

Details

(Whiteboard: [swag:1.5d] 181b1+) 

Remove the hardcoded "Google" sting from bug 337774 and provide a means of updating the list based on the prefs from bug 338598.
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Priority: -- → P1
Target Milestone: Firefox 2 → Firefox 2 beta1
Whiteboard: [swag:1.5d]
Flags: blocking-firefox2? → blocking-firefox2+
I've added support for this.  The pref to set a provider is browser.safebrowsing.dataProvider, and int.  The provider names are browser.safebrowsing.provider.0.name, browser.safebrowsing.provider.1.name, etc.
Whiteboard: [swag:1.5d] → [swag:1.5d] 181b1+
jwalden: does this now count as a dupe against 340677?
(In reply to comment #2)
> jwalden: does this now count as a dupe against 340677?

For some definition of "dynamically".  If you update the preferences while the dialog is open (I don't know whether this is actually possible using a sanctioned method of installing safebrowsing providers, but you could do it with about:config), the dialog won't update too, but reopening the dialog will regenerate the update provider menupopup entries.
Depends on: pref-reorg
That's an edgy-enough case to satisfy me. I don't think this needs to live update.

*** This bug has been marked as a duplicate of 340677 ***
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
No longer depends on: pref-reorg
Resolution: --- → DUPLICATE
Flags: blocking-firefox2+
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.