Closed
Bug 339384
Opened 18 years ago
Closed 18 years ago
Make Bugzilla::Milestone use Bugzilla::Object
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: mkanat, Assigned: mkanat)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
8.95 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Comment 1•18 years ago
|
||
Milestones have neither an ID nor a name. How do you want to use Bugzilla::Object in this case?
Assignee | ||
Comment 2•18 years ago
|
||
(In reply to comment #1) > Milestones have neither an ID nor a name. How do you want to use > Bugzilla::Object in this case? Oh. Well, perhaps we should change the table around. Or we can do something clever with the object. :-) I don't know, yet. :-) Let's see when we get there.
Comment 3•18 years ago
|
||
We are in "soft freeze" mode to prepare 3.0 RC1.
Target Milestone: Bugzilla 3.0 → Bugzilla 3.2
Updated•18 years ago
|
Summary: Make Bugzilla:Milestone use Bugzilla::Object → Make Bugzilla::Milestone use Bugzilla::Object
Assignee | ||
Comment 4•18 years ago
|
||
Re-targeted to 3.0 for performance reasons.
Keywords: perf
Target Milestone: Bugzilla 3.2 → Bugzilla 3.0
Assignee | ||
Comment 5•18 years ago
|
||
I realized that in the version bug, I added the column to the wrong table in DB::Schema! So I'm adding it to the versions table here. (I already added it to the milestones table in the Version bug.)
Comment 6•18 years ago
|
||
Comment on attachment 249081 [details] [diff] [review] v1 r=LpSolit
Attachment #249081 -
Flags: review?(LpSolit) → review+
Updated•18 years ago
|
Flags: approval?
Updated•18 years ago
|
Flags: approval? → approval+
Comment 7•18 years ago
|
||
I'm doing the checkin myself as mkanat is gone and Bugzilla is broken for new installations. Checking in editmilestones.cgi; /cvsroot/mozilla/webtools/bugzilla/editmilestones.cgi,v <-- editmilestones.cgi new revision: 1.57; previous revision: 1.56 done Checking in editproducts.cgi; /cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v <-- editproducts.cgi new revision: 1.132; previous revision: 1.131 done Checking in importxml.pl; /cvsroot/mozilla/webtools/bugzilla/importxml.pl,v <-- importxml.pl new revision: 1.70; previous revision: 1.69 done Checking in Bugzilla/Milestone.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Milestone.pm,v <-- Milestone.pm new revision: 1.8; previous revision: 1.7 done Checking in Bugzilla/Product.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Product.pm,v <-- Product.pm new revision: 1.24; previous revision: 1.23 done Checking in Bugzilla/DB/Schema.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v <-- Schema.pm new revision: 1.80; previous revision: 1.79 done Checking in Bugzilla/Install/DB.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v <-- DB.pm new revision: 1.25; previous revision: 1.24 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•