339634 - GLib-GObject-CRITICAL **: gtype.c:2215: initialization assertion failed, use IA__g_type_init() prior to this function

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Andrew Schultz]

With today's trunk build, I get "(process:14288): GLib-GObject-CRITICAL **: gtype.c:2215: initialization assertion failed, use IA__g_type_init() prior to this function" during component regristration of nsAccessibilityModule.  This is probably from bug 339314

Comment 1

[Ginn Chen]

seems it only happens with release build.

Comment 2

[Ginn Chen]

gtk_init is called after g_type_register_static

the problem is the AtkTypeForMai array, initialization of this array will cause gtype registering in libatk.
with release build, it happens earlier than gtk_init in nsAppRunner.cpp

Comment 3

[Ginn Chen]

Attachment: patch

use switch-case instead of array to avoid earlier initialization.

this bug only happens to release build because release build uses --enable-static, so the array will be initialized before firefox starts.
Otherwise it will be initialized when libaccessibility.so loads, which is after gtk_init().

Comment 4

[Ginn Chen]

This bug causes gecko a11y doesn't work on Linux.

Comment 5

[Ginn Chen]

Attachment: patch

fix some styles.

roc, Aaron is on vacation this week, this bug is a blocker of a11y on Linux
can you review this patch?

Thanks.

Comment 6

[Adam Guthrie]

*** Bug 339718 has been marked as a duplicate of this bug. ***

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 223750 [details] [diff] [review]
patch

+static const GType GetAtkTypeForMai(MaiInterfaceType type)

"const" is meaningless here, remove it.

+    if (typeRegCount++ > 4095) {
+        return G_TYPE_INVALID;
     }

I think you want >= here. With >, it might try to register 4096 types.

Comment 8

[Ginn Chen]

Checking in src/atk/nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAccessibleWrap.cpp,v  <--  nsAccessibleWrap.cpp
new revision: 1.33; previous revision: 1.32
done