339810 - nsWindowsHooks uses static nsCStrings

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

nsWindowsHooks declares static RegistryEntry structures which use nsCStrings.
However although the Windows CRT is quite good at running all the constructors and destructors the use of static nsCStrings is frowned upon.
In trunk debug builds this is exposed by the many thousands of TLS assertions.

Comment 1

[[e-mail]]

Attachment: Proposed patch

* Added nsWindowsHooksUtil.cpp as a real CPP source
* Moved all of the registry classe definitions to a new nsWindowsHooksUtil.h
* Moved all the static variables to be members of the singleton nsWindowsHooks
* Stored the singleton in a global so that nsWindowsHooksSettings can access it

I know the global singleton is a hack but I'd prefer to address that separately.

Comment 2

[jag (Peter Annema)]

Comment on attachment 223919 [details] [diff] [review]
Proposed patch

Bug # for follow-up work?

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 223919 [details] [diff] [review]
Proposed patch

No more asserts with the patch.  I didn't read it though.  r=me.

Comment 4

[[e-mail]]

Fix checked in.

Comment 5

[[e-mail]]

(In reply to comment #2)
>Bug # for follow-up work?
Actually, I must have lxr'd for the wrong string.
When I lxr'd for registryMatches today there was only one consumer,
and it needs to work the way the code is writen now,
as it gets a temporary settings object and sets dummy values on it.