Closed Bug 340050 Opened 18 years ago Closed 18 years ago

Crash in spellchecker checking absurdly long word

Categories

(Core :: Spelling checker, defect)

Product:
Core
Component:
Spelling checker
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta2

People

(Reporter: roc, Assigned: brettw)

References

Details

(Keywords: crash, fixed1.8.1, verified1.8.1.3)

Attachments

(2 files)

gdb stack
17.55 KB, text/plain
Details
Patch
1.56 KB, patch
roc
: review+
roc
: superreview+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
Try loading the testcase here and enabling spellchecking in the edit control:

https://bugzilla.mozilla.org/attachment.cgi?id=219142&action=edit

(You may crash just trying to display the testcase, in which case you'll have to wait for bug 302294 to be fixed before you work on this.)

If I enable spellchecking then click around a fair bit, including right-clicking on the word to get a popup, I eventually crash in mozMySpell::Suggest doing an illegal free.
Flags: blocking1.9a1?
Flags: blocking1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
Severity: normal → major
Keywords: crash
Target Milestone: --- → mozilla1.8.1beta2
Attached patch Patch — — Splinter Review 
This seems to fix the problem. It filters out very long words from myspell. I'm a little worried because I don't understand the source of the problem, and there could be more problems with word handling in myspell.
Attachment #230764 - Flags: review?(roc)
Attachment #230764 - Flags: superreview+
Attachment #230764 - Flags: review?(roc)
Attachment #230764 - Flags: review+
Fixed on trunk.
Assignee: mscott → brettw
OS: Linux → All
Hardware: PC → All
Whiteboard: [at risk]
Version: Trunk → 1.8 Branch
Attachment #230764 - Flags: approval1.8.1?
Attachment #230764 - Flags: approval1.8.1? → approval1.8.1+
Now it's really fixed on trunk.
The first comment about fixing it on trunk was actually a branch checkin.
Keywords: fixed1.8.1
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: blocking1.9a1?
Resolution: --- → FIXED
verified fixed 1.8.1.3 on Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4pre) Gecko/2007040403 BonEcho/2.0.0.4pre and also Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 using the testcase in this bug
Keywords: verified1.8.1.3
Depends on: 629719
Severity: major → critical
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: