340517 - windows native theme broken (with classic theme)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Download todays FF or SeaMonkey nightly
2. Start up
3. Look at various sites, open tabs, etc.

You'll for example notices these issues:
When hovering over a textbox/textarea, the border of the textarea will disappear.
When opening a new tab, the urlbar moves to where the tabbar is and the place where the urlbar should be gets a gray background color.
No vertical scrollbar on websites which require one.
Text on HTML form buttons appears in the wrong place, buttons are cut off, etc.
etc.

This worked fine in yesterdays nightly, so probably Bug 340452 causes this bug here and all the problems connected to it.

Comment 1

[Peter van der Woude [:Peter6]]

This appears to be a win2k-only problem, various people on XP have no problem at all

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #1)
> This appears to be a win2k-only problem, various people on XP have no problem
> at all

It's wrong. I can reproduce on WinXP with classic theme.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that the cause is that the |SetViewportOrgEx| was changed the position in |nsNativeThemeWin::DrawWidgetBackground| by bug 340452. But I cannot test it until return to my home...

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Hmm, I must have forgotten to check something in.. looking

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

*** Bug 340484 has been marked as a duplicate of this bug. ***

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I can't reproduce locally; updating my tree and grabbing the latest nightly to test.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Ok, reproduced with classic theme.  Ugh.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix classic themes

Forgot to make the "-" -> "+" change for the classic case.  (This duplicated code needs to be refactored.)

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in; sorry for the breakage!

Comment 10

[Peter van der Woude [:Peter6]]

thanks for the quick fix

Comment 11

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060606 Minefield/3.0a1 ID:2006060613 [cairo]

verified fixed on win2k/classic

Comment 12

[José Jeria]

*** Bug 340678 has been marked as a duplicate of this bug. ***