341245 - Remove some unused box object related interfaces

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

There are some interfaces in layout/xul/base/public which aren't used at all.
for example nsIBoxLayoutManager and nsIBoxPaintManager.
I think those can be removed.

nsIBrowserBoxObject, nsIIFrameBoxObject and nsIEditorBoxObject have all just
one attribute, |readonly attribute nsIDocShell docShell|
IMO, those could be merged to nsIDocShellContainer or whatever would be a good
name.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: something like this

Perhaps Neil has some comments to this :)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: part 2 of the patch

This was missing from the patch

Comment 3

[[e-mail]]

Comment on attachment 225273 [details] [diff] [review]
something like this

After the mess of bug 340084 I don't feel qualified to review this. However, I'd name the class nsContainerBoxObject etc. I'd also use FORWARD_NSICONTAINERBOXOBJECT(nsBoxObject::)

Comment 4

[Boris Zbarsky [:bzbarsky]]

> one attribute, |readonly attribute nsIDocShell docShell|

Which I'd like to go away in favor of an nsIWebNavigation, frankly....  any time our chrome uses nsIDocShell, we have a bug, imo.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 225273 [details] [diff] [review]
something like this

Boris, do you want to say something else about this.
I agree with Neil that nsIContainerBoxObject would be a better name.

Changing the attribute to nsIWebNavigation is a different bug. (But I'll investigate that too :) )

Comment 6

[Boris Zbarsky [:bzbarsky]]

smaug, I'm pretty totally swamped right now; I won't be able to do a detailed review of something like this probably until July.  :(

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 225273 [details] [diff] [review]
something like this

Ok, I'll try someone else...

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

This contains both patches, uses name ContainerBoxObject and ::GetDocShell
moved to ContainerBoxObject since it was not needed in nsBoxObject.
The previous patch was also missing some deleted files; this one has quite good
+/- ratio :) +261/-837 lines

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is actually a XUL API change. People who were using the old nsIEditorBoxObject etc interfaces will be broken. I suspect that's a bad idea.

How about we define nsIEditorBoxObject, nsIBrowserBoxObject, and nsIIFrameBoxObject, make them all just inherit from nsIContainerBoxObject adding no new methods, and then implement them as tearoffs on nsContainerBoxObject?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Keeping interfaces for browser, iframe and editor

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 228998 [details] [diff] [review]
Keeping interfaces for browser, iframe and editor

OK.

Removing the layout and paint managers is technically an interface change, but since no objects implementing those interfaces ever existed, I think we'll be OK.