Closed
Bug 341276
Opened 18 years ago
Closed 18 years ago
(1.8 branch) assertion from javascript alerts
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: dbaron, Assigned: bzbarsky)
References
()
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
1.07 KB,
patch
|
Details | Diff | Splinter Review |
In Firefox on the 1.8 branch, I see an assertion every time javascript does an alert (these line numbers may be a bit off because I've got a lot of changes in my tree, but I don't think they're related to this): ###!!! ASSERTION: aOriginalOpener is true, but we already have a document loaded: '!aOriginalOpener || !mDocument', file /builds/1.8/mozilla/dom/src/base/nsGlobalWindow.cpp, line 1512 Break: at file /builds/1.8/mozilla/dom/src/base/nsGlobalWindow.cpp, line 1512 nsDebugImpl::Break(char const*, int) (/builds/1.8/mozilla/xpcom/base/nsDebugImpl.cpp:319) nsDebugImpl::Assertion(char const*, char const*, char const*, int) (/builds/1.8/mozilla/xpcom/base/nsDebugImpl.cpp:268) NSGlue_Assertion (/builds/1.8/obj/firefox-debugopt/xpcom/build/nsDebug.cpp:107) nsGlobalWindow::SetOpenerWindow(nsIDOMWindowInternal*, int) (/builds/1.8/mozilla/dom/src/base/nsGlobalWindow.cpp:1514) nsWindowWatcher::ReadyOpenedDocShellItem(nsIDocShellTreeItem*, nsIDOMWindow*, int, nsIDOMWindow**) (/builds/1.8/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp:1686) nsWindowWatcher::OpenWindowJSInternal(nsIDOMWindow*, char const*, char const*, char const*, int, unsigned int, long*, int, nsIDOMWindow**) (/builds/1.8/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp:762) nsWindowWatcher::OpenWindow(nsIDOMWindow*, char const*, char const*, char const*, nsISupports*, nsIDOMWindow**) (/builds/1.8/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp:481) nsPromptService::DoDialog(nsIDOMWindow*, nsIDialogParamBlock*, char const*) (/builds/1.8/mozilla/embedding/components/windowwatcher/src/nsPromptService.cpp:659) nsPromptService::Alert(nsIDOMWindow*, unsigned short const*, unsigned short const*) (/builds/1.8/mozilla/embedding/components/windowwatcher/src/nsPromptService.cpp:132) nsPrompt::Alert(unsigned short const*, unsigned short const*) (/builds/1.8/mozilla/embedding/components/windowwatcher/src/nsPrompt.cpp:217) nsGlobalWindow::Alert(nsAString_internal const&) (/builds/1.8/mozilla/dom/src/base/nsGlobalWindow.cpp:3365) these assertions were added to the branch by: revision 1.761.2.36 date: 2006/05/15 17:35:10; author: bzbarsky%mit.edu; state: Exp; lines: +30 -9 Keep track of the original window opener (or rather whether one was present) even if window.open calls target the window. Bug 266371 and bug 212298, r=bsmedberg, sr=jst, branch181=jst
Reporter | ||
Updated•18 years ago
|
Flags: blocking1.8.1?
Assignee | ||
Comment 1•18 years ago
|
||
This assert is just bogus. See bug 266371 comment 25 and bug 266371 comment 26. I've removed it on the 1.8 branch as well; it should never have landed to start with.
Assignee | ||
Comment 2•18 years ago
|
||
Fixed.
Assignee | ||
Updated•18 years ago
|
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•