341278 - Status bar priority

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[acoolie]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.3) Gecko/20060427 Camino/1.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.3) Gecko/20060427 Camino/1.0.1

When loading a page, Camino shows things such as "Connecting to..." and others. These messages are helpful usually, but when trying to find out where a link goes (A feature normally implemented in Camino), it is quite hard to see. The instant a new connection is made, the href of the link goes away. Basically, I feel that link location should have priority over most other messages in the status bar.

Reproducible: Always

Steps to Reproduce:
1. Go to google.com (Or maybe a page that takes longer to load)
2. Quickly hover over a link

Actual Results:  
The link location quickly disappears.

Expected Results:  
The link location should stay in place until mouseout.

Comment 1

[Stuart Morgan]

Confirming.  This should be reasonable to do, since it looks like the link information is coming in through setStatus:OfType, whereas the various loading strings are coming from onLoadingStarted/onLoadingCompleted/onStatusChange:.

Taking.

Comment 2

[Stuart Morgan]

Attachment: prioritize status strings

fix

Comment 3

[Stuart Morgan]

>+  eStatusLinkTarget    = 0, // like mouseover info

That should read 'link mouseover info'; I'll fix that on respin after it's reviewed.

Comment 4

[Chris Lawson (gone)]

Comment on attachment 243442 [details] [diff] [review]
prioritize status strings

r=cl. Looks good.

>-  mTabTitle = [mLoadingStatusString retain];
>+  mTabTitle = [NSLocalizedString(@"TabLoading", @"") retain];

This doesn't require any string changes, does it?

cl

Comment 5

[Stuart Morgan]

Comment on attachment 243442 [details] [diff] [review]
prioritize status strings

Nope, same string we've always used.

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 243442 [details] [diff] [review]
prioritize status strings

sr=pink

in the .h, |mStatusStrings| should have a comment that it's a strong (owning) reference.

Comment 7

[Stuart Morgan]

Attachment: with comments

As checked into trunk and MOZILLA_1_8_BRANCH