342408 - [BeOS] Mouse handling for IFRAMEs is broken after scroll

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Sergei Dolgov]

That's result of hiding children for perfect scrolling. Hidden BViews don't get mouse notifications, so mouse events do pass to wrong widget.

Solution. Unhide kids in the end of scroll function, but perform some additional actions to minimize unneeded invalidation.

Comment 1

[Sergei Dolgov]

Attachment: patch

Calls HideKids(PR_FALSE) in end of Scroll() methods.
Removed HideKids() from other places.
Adds two little methods to nsViewBeOS - SetVisible() and Visible().
SetVisible() is used in Scroll() to stop any OS-forced invalidation until end of process. Without it Hide/UnhideKids at each scroll event is too expensive.
nsWindow::IsVisible() now also takes in account nsViewBeOS::Visible().

SetVisible()/Visible() might be used in future in other places too, like ::Invalidate().

(Also fixed initial size of gCursorArray)
r=?

Comment 2

[Sergei Dolgov]

tqh, there is some code in this patch which relates to ArgvReceived/RefsReceived patch, don't take it in account - it will be removed at checkin, as this is already in tree anyway:)

Comment 3

[tqh]

Comment on attachment 226648 [details] [diff] [review]
patch

r=[e-mail]
Havn't tried it, but it looks ok. Also check formatting before checkin as I just looked at function.

Comment 4

[Sergei Dolgov]

Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.127; previous revision: 1.126
done
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.57; previous revision: 1.56
done

Comment 5

[Sergei Dolgov]

Needs to be backported to branch. Probably together with bug
https://bugzilla.mozilla.org/show_bug.cgi?id=342613

Fixes quite serious usability issue, will attempt that when at home

Comment 6

[Doug Shelton]

(In reply to comment #5)
> Needs to be backported to branch. Probably together with bug
> https://bugzilla.mozilla.org/show_bug.cgi?id=342613
> 
> Fixes quite serious usability issue, will attempt that when at home
> 

I'll see if I can paste this into the branch code tonight.

Comment 7

[Sergei Dolgov]

Attachment: patch version for branch

asking approval for branch,
BeOS-only change.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 241832 [details] [diff] [review]
patch version for branch

a=beltzner on behalf of drivers (NPOTB)

Comment 9

[Sergei Dolgov]

Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.35.4.14; previous revision: 1.35.4.13
done
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.23; previous revision: 1.91.4.22
done