342410 - Various modules assume functions are in global scope, when none are

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Max Kanat-Alexander]

Bugzilla::User has a bunch of silly calls to &::Param, which is not a global function.

Bugzilla::Chart has some calls to &::ThrowUserError, which is also not a global function.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Pretty trivial fix.

Comment 2

[Frédéric Buclin]

Comment on attachment 226639 [details] [diff] [review]
v1

process_bug.cgi also uses some constants as global:

1760:        unless ($control > &::CONTROLMAPNA)  {
1763:        if ($control == &::CONTROLMAPMANDATORY) {


Your patch looks good. r=LpSolit

Comment 3

[Max Kanat-Alexander]

Checking in Bugzilla/Chart.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Chart.pm,v  <--  Chart.pm
new revision: 1.13; previous revision: 1.12
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.113; previous revision: 1.112
done

Comment 4

[Vlad Dascalu]

Checked in on the Erbix branch:

Checking in Bugzilla/Chart.pm;
/cvs/erbix-code/Bugzilla/Chart.pm,v  <--  Chart.pm
new revision: 1.2; previous revision: 1.1
done
Checking in Bugzilla/User.pm;
/cvs/erbix-code/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.2; previous revision: 1.1
done