342584 - Error always appears while reviewing, if you own an add-on in the queue

Status: VERIFIED DUPLICATE of bug 350904

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Tim Horton]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.0.3705; .NET CLR 1.1.4322; Media Center PC 4.0)
Build Identifier: 

Each and every time I review an extension, whether I accept or reject it, I get the following error message:

Error: Denial cannot be processed because of missing data. Fill in the required fields and try again.

However, above this, I get a message telling me that the change was successful, and the extension falls out of the queue!

Reproducible: Always

Steps to Reproduce:
1. Review an extension
2. Submit
3. View the results (at the top of the next page)

Actual Results:  
The action happens, but Update returns a message:

Error: Denial cannot be processed because of missing data. Fill in the required fields and try again.

Expected Results:  
The action should happen, and I should ONLY recieve the confirmation of the action.

Comment 1

[Cameron]

You must fill in the OS, App and comments field and check ALL the boxes to approve an Add-on.

You must fill in the OS, App and comments fields to deny an add-on.

Are you doing that?

Comment 2

[Tim Horton]

(In reply to comment #1)
> You must fill in the OS, App and comments field and check ALL the boxes to
> approve an Add-on.
> 
> You must fill in the OS, App and comments fields to deny an add-on.
> 
> Are you doing that?
> 
 Yep. I'm filling everything in, and MY action happens - lets say I accept one extension. I get 'such and such was accepted' and the right under it, 'Error: Denial cannot be processed because of missing data. Fill in the required fields and try again.'

That second message is _always_ one about denial, even if I was only accepting an extension.

So - it doesn't actually break anything, it just leaves an annoying message that sometimes makes me think I screwed up...

Comment 3

[Tim Horton]

I think I know what's causing this now. I just reviewed an extension _below_ my own in the list, and voila! The error message comes first, before the acceptance line.

So - I'm saying that it only happens if you have an extension of your own in the queue.

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Confirming, adjusting summary, etc.

Comment 5

[alanjstr]

*** Bug 343399 has been marked as a duplicate of this bug. ***

Comment 6

[Justin Scott [:fligtar]]

I fixed this a couple weeks ago after submitting my own bug for it - didn't know there was already one. Oops!

Anyway, this is fixed now.

*** This bug has been marked as a duplicate of 350904 ***