342635 - wrong scroll behaviour after loading new page while session restoring

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[christoph.reiter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1a3) Gecko/20060624 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1a3) Gecko/20060624 BonEcho/2.0a3

i have "browser.sessionstore.resume_session" = true...

1. open a side with long content (scrollbar)
2. scroll down
3. close FF
4. open again and click on a bookmark before session is restored(page is loaded).
5. FF will scroll down to the position but on the wrong(new) page.

Reproducible: Always

Comment 1

[Ria Klaassen (not reading all bugmail)]

I see the same with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060624 Minefield/3.0a1

Comment 2

[Simon Bünzli]

Attachment: possible fix

This is an untested patch which should fix the issue by making sure that we've actually loaded the URL we intended to before restoring scrolling state (and text data).

Comment 3

[Simon Bünzli]

Attachment: unbitrotted

Comment 4

[Asaf Romano (gone)]

Comment on attachment 331804 [details] [diff] [review]
unbitrotted

Then we shouldn't dispatch SSTabRestored either. I would rather remove all event listeners if pagehide was dispatched during page-restore.

Comment 5

[Simon Bünzli]

Attachment: patch as per comment #4

With this patch, we won't (try to) restore a page that's already been unloaded.

Comment 6

[Simon Bünzli]

Comment on attachment 332145 [details] [diff] [review]
patch as per comment #4

This breaks e.g. Bugzilla pages where we always get a pagehide event for bug lists before the actual list is displayed. Guess we'll have to check the loaded URL instead, nonetheless.

Comment 7

[Simon Bünzli]

Attachment: more comprehensive, working fix

This patch doesn't listen for pagehide events, it is however more comprehensive in what doesn't happen when the loaded page isn't the page that was supposed to be loaded (among others, we no longer dispatch the SSTabRestored event).

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 334077 [details] [diff] [review]
more comprehensive, working fix

r=me

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/63f6591b1238

Comment 10

[Michael Kohler [:mkohler]]

Verified with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090617 Minefield/3.6a1pre ID:20090617031528

Comment 11

[u279076]

in-litmus+
https://litmus.mozilla.org/show_test.cgi?id=7789