342806 - Suiterunner Add-ons "Install Now" button should be removed

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Justin Wood (:Callek)]

Give a lack of "Extension/Theme Manager" component here, filing in general.

After Bug 342656 landed we now have the ability (and definately the desire) to follow suite with Firefox by hiding the button.

Should be a simple case of: 	

 // Hides the install button in the add-ons mgr
 pref("extensions.hideInstallButton", true);

In our prefs file.

Comment 1

[Giacomo Magnini]

Attachment: Is this enough?

Comment 2

[Giacomo Magnini]

Comment on attachment 243220 [details] [diff] [review]
Is this enough?

Change of reviewer, since CTho isn't usually building suiterunner...

Comment 3

[[e-mail]]

Comment on attachment 243220 [details] [diff] [review]
Is this enough?

Although I'm concerned that it's not so easy to install a theme (extensions you can just open in the browser).

Comment 4

[Giacomo Magnini]

(In reply to comment #3)
> (From update of attachment 243220 [details] [diff] [review] [edit])
> Although I'm concerned that it's not so easy to install a theme (extensions you
> can just open in the browser).

I agree with Neil: it's much more logical to show the install button, and refuse to install an xpi by Open file..., so that addons are logically enforced to be managed by the addon manager only.
Just my €.02...

Comment 5

[Justin Wood (:Callek)]

Hmm, seems to have slipped through the cracks; Still wanted...

I haven't tested that this still applies, so if there is a conflict here I'll submit an updated patch.

Comment 6

[Reed Loden [:reed]]

Checking in suite/browser/browser-prefs.js;
/cvsroot/mozilla/suite/browser/browser-prefs.js,v  <--  browser-prefs.js
new revision: 1.69; previous revision: 1.68
done

Comment 7

[Karsten Düsterloh]

Sorry, but I don't see _any_ justification why this button should be hidden?
This is just plain annoying, especially since it doesn't solve any problem or something...

Comment 8

[Justin Wood (:Callek)]

because it is intended to be shown for apps without the built-in UI to *browse* to a site which contains the addon.  We Do.

I don't think its worth exposing the install now as 99.99% of users will not be *downloading* an xpi then trying to install it; rather they will be browsing the web, addons.m.o for example, and click to install; getting the regular UI.

The button was needed for Thunderbird to have a discoverable way to install addons, in SeaMonkey I don't feel the few who would use it/want it warrants having the pref flipped by default (or exposed in pref UI).

Comment 9

[Karsten Düsterloh]

Having an Addon-Manager which can't install addons is just weird.
- It's inconsistent, non-obvious and counter-intuitive.
- It makes "download once, install offline/often" very hard and non-obvious. Many users (as seen in newsgroups and mails I got) maintain SM based installations for their family/friends and are downloading addons on memory sticks etc. to install them offline, on several mechines. Our capability of browsing the local file system in the browser is very obscure and unwieldy (in short: user-unfriendly).

Hiding the button doesn't solve any problems, it's just taking away a useful and logical way of installing extensions...

I think we should back out this change.