343212 - Clear private data...>Browsing History should also clear the 'Undo Close Tab' history

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mathieu Pellerin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060629 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060629 BonEcho/2.0a3

Bug 254021 introduced a restore closed tab(s) function but the clear private data tool doesn't remove the closed tab history, potentially disclosing personal information reachable after leaving the user with a false feeling of having cleaned everything by closing the sensitive tab + cleaning browsing history.

Reproducible: Always

Steps to Reproduce:
1.Open two tabs, close one of them
2.Open the Clear Private Data tool, and clean the 'Browsing History' item
3.Go back to your main window and try to undo the last closed tab

Actual Results:  
The last closed tab shows up

Expected Results:  
All my previously closed tabs should be cleaned out

Comment 1

[Jesse Ruderman]

Should *disabling* history also disable the Undo Close Tab feature?

Comment 2

[Simon Bünzli]

Attachment: fix

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #1)
> Should *disabling* history also disable the Undo Close Tab feature?

I don't think so, since we don't keep the previously closed tabs beyond a single session. But maybe. I'm just not sure that the user who doesn't want their browsing history recorded is also expecting to lose undo-close-tab functionality as a tradeoff.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

--> blocking, TM beta2, will accept patches earlier if they're reviewed, landed and baked.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 227775 [details] [diff] [review]
fix

I'd rather use i than ix, to be consistent with the rest of the codebase, otherwise r=me

Comment 6

[Simon Bünzli]

(In reply to comment #5)
> I'd rather use i than ix, to be consistent with the rest of the codebase,
> otherwise r=me

ix should be OK since we're not iterating over integer values but hash keys (which BTW is quite consistent all through nsSessionStore.js).

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/sessionstore/src/nsSessionStore.js 	1.28

Comment 8

[Hussam Al-Tayeb]

Is this check in for firefox 2.0 yet or only on trunk?

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 227775 [details] [diff] [review]
fix

Problem: the undo-close-tab data is not cleared when session history is cleared.

Solution: clear it out upon receiving the browser:purge-session-history notification.

Risk: Low

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 227775 [details] [diff] [review]
fix

a=drivers. Please land on the MOZILLA_1_8_BRANCH.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 227775 [details] [diff] [review]
fix

a=drivers. Please land on the MOZILLA_1_8_BRANCH.

Comment 12

[Dietrich Ayala (:dietrich)]

This is checked in on branch, but unconfirmed in the latest build b/c clearing browser history is throwing errors. (I don't see them in my local build, just in the tinderbox build)

I'll look and see if this is related to this patch, or filed, etc.

Comment 13

[Dietrich Ayala (:dietrich)]

The error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistory.PurgeHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: observe :: line 654" data: no]

Comment 14

[Bryan]

(In reply to comment #13)
> The error: [Exception... "Component returned failure code: 0x80004005
> (NS_ERROR_FAILURE) [nsISHistory.PurgeHistory]" nsresult: "0x80004005
> (NS_ERROR_FAILURE)" location: "JS frame ::
> chrome://global/content/bindings/browser.xml :: observe :: line 654" data: no]

See BUG: https://bugzilla.mozilla.org/show_bug.cgi?id=342642

~B

Comment 15

[:Gavin Sharp [email: [e-mail]]]

This is already checked in.

Comment 16

[Bryan]

Also... Shouldn't there be an option to enable/disable this in the configuration for "Clear Private Data" to be consistent?

~B

Comment 17

[Bryan]

(In reply to comment #16)
> Also... Shouldn't there be an option to enable/disable this in the
> configuration for "Clear Private Data" to be consistent?
> 
> ~B
NM, I see this is tied to browsing history in "Clear Private Data".  Makes sense!

~B 

Comment 18

[Adam Guthrie]

*** Bug 348566 has been marked as a duplicate of this bug. ***