Closed
Bug 343212
Opened 18 years ago
Closed 18 years ago
Clear private data...>Browsing History should also clear the 'Undo Close Tab' history
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: nirvn.asia, Assigned: zeniko)
References
Details
(Keywords: fixed1.8.1, privacy)
Attachments
(1 file)
1.58 KB,
patch
|
mconnor
:
review+
beltzner
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060629 BonEcho/2.0a3 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060629 BonEcho/2.0a3 Bug 254021 introduced a restore closed tab(s) function but the clear private data tool doesn't remove the closed tab history, potentially disclosing personal information reachable after leaving the user with a false feeling of having cleaned everything by closing the sensitive tab + cleaning browsing history. Reproducible: Always Steps to Reproduce: 1.Open two tabs, close one of them 2.Open the Clear Private Data tool, and clean the 'Browsing History' item 3.Go back to your main window and try to undo the last closed tab Actual Results: The last closed tab shows up Expected Results: All my previously closed tabs should be cleaned out
Comment 1•18 years ago
|
||
Should *disabling* history also disable the Undo Close Tab feature?
Flags: blocking-firefox2?
Keywords: privacy
Assignee | ||
Updated•18 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•18 years ago
|
||
Comment 3•18 years ago
|
||
(In reply to comment #1) > Should *disabling* history also disable the Undo Close Tab feature? I don't think so, since we don't keep the previously closed tabs beyond a single session. But maybe. I'm just not sure that the user who doesn't want their browsing history recorded is also expecting to lose undo-close-tab functionality as a tradeoff.
Comment 4•18 years ago
|
||
--> blocking, TM beta2, will accept patches earlier if they're reviewed, landed and baked.
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: --- → Firefox 2 beta2
Comment 5•18 years ago
|
||
Comment on attachment 227775 [details] [diff] [review] fix I'd rather use i than ix, to be consistent with the rest of the codebase, otherwise r=me
Attachment #227775 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 6•18 years ago
|
||
(In reply to comment #5) > I'd rather use i than ix, to be consistent with the rest of the codebase, > otherwise r=me ix should be OK since we're not iterating over integer values but hash keys (which BTW is quite consistent all through nsSessionStore.js).
Whiteboard: [checkin needed]
Comment 7•18 years ago
|
||
mozilla/browser/components/sessionstore/src/nsSessionStore.js 1.28
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] → [need-a]
Comment 8•18 years ago
|
||
Is this check in for firefox 2.0 yet or only on trunk?
Updated•18 years ago
|
Whiteboard: [need-a] → [has patch][needs approval]
Comment 9•18 years ago
|
||
Comment on attachment 227775 [details] [diff] [review] fix Problem: the undo-close-tab data is not cleared when session history is cleared. Solution: clear it out upon receiving the browser:purge-session-history notification. Risk: Low
Attachment #227775 -
Flags: approval1.8.1?
Comment 10•18 years ago
|
||
Comment on attachment 227775 [details] [diff] [review] fix a=drivers. Please land on the MOZILLA_1_8_BRANCH.
Attachment #227775 -
Flags: review+
Comment 11•18 years ago
|
||
Comment on attachment 227775 [details] [diff] [review] fix a=drivers. Please land on the MOZILLA_1_8_BRANCH.
Attachment #227775 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [has patch][needs approval] → [checkin needed (1.8 branch)]
Comment 12•18 years ago
|
||
This is checked in on branch, but unconfirmed in the latest build b/c clearing browser history is throwing errors. (I don't see them in my local build, just in the tinderbox build) I'll look and see if this is related to this patch, or filed, etc.
Whiteboard: [checkin needed (1.8 branch)]
Comment 13•18 years ago
|
||
The error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistory.PurgeHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: observe :: line 654" data: no]
Comment 14•18 years ago
|
||
(In reply to comment #13) > The error: [Exception... "Component returned failure code: 0x80004005 > (NS_ERROR_FAILURE) [nsISHistory.PurgeHistory]" nsresult: "0x80004005 > (NS_ERROR_FAILURE)" location: "JS frame :: > chrome://global/content/bindings/browser.xml :: observe :: line 654" data: no] See BUG: https://bugzilla.mozilla.org/show_bug.cgi?id=342642 ~B
Updated•18 years ago
|
Whiteboard: [checkin needed (1.8 branch)]
Comment 15•18 years ago
|
||
This is already checked in.
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Comment 16•18 years ago
|
||
Also... Shouldn't there be an option to enable/disable this in the configuration for "Clear Private Data" to be consistent? ~B
Comment 17•18 years ago
|
||
(In reply to comment #16) > Also... Shouldn't there be an option to enable/disable this in the > configuration for "Clear Private Data" to be consistent? > > ~B NM, I see this is tied to browsing history in "Clear Private Data". Makes sense! ~B
Comment 18•18 years ago
|
||
*** Bug 348566 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•