343303 - onblur fires before onchange for comboboxes

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We used to fire onchange before onblur.  To reproduce:

1)  Load https://bugzilla.mozilla.org/attachment.cgi?id=227653&action=view
2)  Tab to the first <select> (the combobox) or focus it with mouse (but have
    it closed).
3)  Hit the down arrow key.
4)  Hit tab

ACTUAL RESULTS:  Output box shows blur, then change

EXPECTED RESULTS:  Change, then blur

I have the following range for this:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-03-05+17&maxdate=2006-03-07+20&cvsroot=%2Fcvsroot

but that's a 2-day range; if someone has builds in between there, that would help narrow it more.

Given the range, the most likely cause looks like the event dispatch changes...

Comment 1

[Ria Klaassen (not reading all bugmail)]

I see the change between 1.9a1_2006030704 and 1.9a1_2006030713.

Comment 2

[Boris Zbarsky [:bzbarsky]]

That gives http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20060307+04+&maxdate=20060307+13&cvsroot=%2Fcvsroot

Really does sound like bug 234455, though I have no idea how....

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

A testcase would be great

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

nm

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Oops, my mistake :)

Put back the old behaviour. In 1.8 the SetFocus call is before event handling.
http://lxr.mozilla.org/mozilla1.8/source/content/html/content/src/nsHTMLSelectElement.cpp#1782
http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsHTMLSelectElement.cpp#1818

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 228031 [details] [diff] [review]
proposed patch

Ah, indeed.  ;)  r+sr=bzbarsky