34339 - boxes aren't properly resizing based on content if content has been hidden again

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Scott MacGregor]

Hey Eric, our old friend is back. We used to have this problem and then you
fixed it a while ago but it appears to have snuck back. I first started noticing
this in Fridays builds which include a lot of boxes changes I think.

Steps to reproduce:
1) View a message in the message pane with a lot of recipients in say the To or
cc line. click on the toggle button to expand the addresses so you can see all
of them. It should take up several lines.

2) Now click on another message that doesn't have as many recipients.

You should see a huge grey space in the box for the To field (or the cc line).
The box is still sized to the content of the first message and did not properly
resize after all the elements from the to field were removed and the new one was
added.

Comment 1

[Scott MacGregor]

I think I can better crystalize the exact problem in case this helps:

The contents of the To field are enclosed within a box. When we remove elements
(titledbuttons) that are inside of this box, the box code is no longer resizing
itself. So we are left with a big gap. I believe this broke with something that
got checked in on Thursday.

Comment 2

[Eric Vaughan]

I believe I fixed this. But when I open my normal email account to set mail just 
take for ever. I just checked in a fix. Can you confirm its fixed and close it 
out if it is? If not can you tell me how to simply reproduce it. For example 
what kind of mail message would I have to send to myself to make this show up?

Comment 3

[Scott MacGregor]

Hey Eric, your changes today did indeed fix this. Thanks! I'll mark it fixed for
you.