343554 - Tab reordering shortcuts can move tabs offscreen

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Asaf Romano (gone)]

I'm running into various senarios in which the selected tab isn't visible.

One senario:
 1. Open many tabs.
 2. Select and focus the last tab.
 3. Press Ctrl+Home (selects the first tab).

One reason would be the use of this.selectedItem in the TabSelect handler. IIRC it still points to the previously selected tab at this point. Unfortunately, even after changing it to use this.childNodes[this.selectedIndex] (which should be fine, see updateCurrentBrowser), this handler doesn't really do its job.

Comment 1

[Mike Connor [:mconnor]]

So, Ctrl+Home moves that tab to the first position, so it misses the tabselect handler entirely.  Same problem with Ctrl+Left/Right and Ctrl+End, easy to reproduce.

We should add a tabmove handler to do the same as the tabselect handler and always ensure the tab is visible.  Not critical path for b1, but should be fixed.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[Asaf Romano (gone)]

Comment on attachment 228135 [details] [diff] [review]
patch

This should be safe enough for b1.

Comment 4

[Asaf Romano (gone)]

trunk: mozilla/toolkit/content/widgets/tabbrowser.xml 1.162

Comment 5

[Asaf Romano (gone)]

1.8 branch: mozilla/toolkit/content/widgets/tabbrowser.xml 1.103.2.52