Closed Bug 343603 Opened 18 years ago Closed 18 years ago

Right clicking Go button activates button (goes to URL in Location Bar)

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta1

People

(Reporter: ispiked, Assigned: Gavin)

References

(
URL
)

Details

(Keywords: fixed1.8.1, regression)

Attachments

(1 file, 1 obsolete file)

as checked in
898 bytes, patch
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060704 Minefield/3.0a1

Steps to reproduce:
1. Right click on the Go button.

Results:
Toolbar context menu is brought up and Firefox "goes" to the URL in the Location Bar.

Expected Results:
Toolbar context menu appears.

I know Gavin touched some of this code in bug 339710.
Hrm... won't this become obsolete once bug 341429 is fixed?
Attached patch patch (obsolete) — — Splinter Review 
duh
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #228107 - Flags: review?(mconnor)
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Firefox 2 beta1
Version: Trunk → 2.0 Branch
Comment on attachment 228107 [details] [diff] [review]
patch

I don't like the /* */ inside the brackets, do // training instead and r=me
Attachment #228107 - Flags: review?(mconnor) → review+
Attached patch as checked in — — Splinter Review 

        Attachment #228107 -
        Attachment is obsolete: true

    
    

    
  
mozilla/browser/base/content/browser.js 	1.656
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 228151 [details] [diff] [review]
as checked in

This is a trivial fix that should land on the 1.8 branch.

        Attachment #228151 -
        Flags: approval1.8.1?

    
  

        Attachment #228151 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
mozilla/browser/base/content/browser.js 	1.479.2.161
Keywords: fixed1.8.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: