343760 - Don't copy nsITextContent into glyph frames

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

The characters in a text node are copied into the glyph frames which means we store each piece of svg text twice.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Get the text from the text content whenever we need it rather than keeping a copy.

Note that this patch changes whitespace handling. Consider the following example:

<text>ab<tspan> cde </tspan>fg</text>

Considering http://www.w3.org/TR/SVG/text.html#WhiteSpace and looking at the xml:space="default" case it seems to me that we should strip out the spaces around the tspan element. Currently we'd not strip either of these spaces.

Also includes an optimisation to get all character advances in one go rather than one at a time. Is the idl correct for that. Surely there is a better way to indicate I want a float ** argument.

Comment 2

[Robert Longson [:longsonr]]

Comment on attachment 228296 [details] [diff] [review]
patch

nsSVGGlyphFrame::GetCharacterPosition changes submitted under bug 343774

Comment 3

[Robert Longson [:longsonr]]

Attachment: patch

Comment 4

[tor]

Comment on attachment 229806 [details] [diff] [review]
patch

Update the uuid for nsISVGGlyphFragmentNode.

Use nsAutoString in GetCharacterData and GetNumberOfCharacters.

File a bug about looking at xml:spac if one doesn't already exist.

With those, r=tor.

Comment 5

[Robert Longson [:longsonr]]

Attachment: address review comments

> Update the uuid for nsISVGGlyphFragmentNode.

Done.

> Use nsAutoString in GetCharacterData and GetNumberOfCharacters.

Done.

> File a bug about looking at xml:spac if one doesn't already exist.

bug 319786 already exists for it.

Comment 6

[Robert Longson [:longsonr]]

Checked in