343762 - Zoom All zooms downloads window (even when it's not visible)

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[froodian (Ian Leue)]

Oops.  My patch for bug 181978 zooms the downloads window even when it's not visible.  STR:

1. Open a browser window (ensuring that the downloads window is closed)
2. Zoom all
3. Open downloads window

This is a good time for a little more discussion on whether we want the downloads window to zoom at all.  I say that it's the app-wide windows menu, and people expect its actions to work on all windows, so we should.  Obviously though, whatever we decide, it should zoom the window if it's not open. (It's an easy fix either way, btw)

Comment 1

[Håkan Waara]

I think all visible windows should be zoomed.

Comment 2

[Peter Jaros (:peeja)]

I don't think the Downloads window should be zoomed.  The Downloads window, in my user experience, is an honorary utility panel.  It's not the main event, and its zoom behavior, while appropriate, is quite different from other windows'.  I wouldn't expect it to zoom.

Comment 3

[froodian (Ian Leue)]

Attachment: Zoom Downloads Solution

This solution zooms all windows, just only if they're open.

Comment 4

[froodian (Ian Leue)]

Attachment: Don't Zoom Downloads Solution

This patch only zooms browser windows.



Once we figure out which of these solutions we want, we can set the review flags on the appropriate patch.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'm with Peter on this one; I think people are more likely going to want all of their browser windows to go full-screen than their browser windows and downloads.

OTOH, it's a fairly harmless action and Safari zooms *all* open windows (even the activity window), so I could be convinced either way.

Comment 6

[Chris Lawson (gone)]

When I Zoom the downloads window now, it doesn't go full-screen. It resizes to fit its content.

Is that not what other people are seeing? Because that behaviour seems perfectly reasonable to me.

cl

Comment 7

[Mike Pinkerton (not reading bugmail)]

it's an easy fix, i say we go with not zooming non-browser windows and we can always pull that out if people complain. 

Comment 8

[froodian (Ian Leue)]

Comment on attachment 228390 [details] [diff] [review]
Don't Zoom Downloads Solution

r=cl per irc

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 228390 [details] [diff] [review]
Don't Zoom Downloads Solution

sr=pink

Comment 10

[Nick Kreeger]

Roasting on trunk and branch.