343766 - localize anti-phishing reporting urls

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Tony Chang (Google)]

Anti-phishing data providers must provide a URL to a report phishing page (see bug 339876).  In particular, up to three URLs are provided: reportGenericURL, reportErrorURL, and reportPhishURL.  These need to be localized to the users language.

We can use {moz:locale} like search plugins do and replace that.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

This bug should depend on bug 339876, but since that one isn't blocking yet, this one won't be.

Comment 2

[Tony Chang (Google)]

Attachment: v1: use {moz:locale} for locale

The changes to browser/app/profile/firefox.js is just to demonstrate how this works.  I realize the final urls will be different.

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 229173 [details] [diff] [review]
v1: use {moz:locale} for locale

This looks fine to me.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 229173 [details] [diff] [review]
v1: use {moz:locale} for locale

Can you just use @AB_CD@, or do you need these URLs to change if general.useragent.locale is changed after install?

Comment 5

[Tony Chang (Google)]

(In reply to comment #4)
> (From update of attachment 229173 [details] [diff] [review] [edit])
> Can you just use @AB_CD@, or do you need these URLs to change if
> general.useragent.locale is changed after install?

I think it'd be better if it changed when the user changes locales.  That said, there ought to be a pref observer for general.useragent.locale so it does actually update without a restart.  I'll cut a new patch.

Comment 6

[Tony Chang (Google)]

Attachment: v2: add locale pref observer

Same as v1 patch + pref observer for locale change.

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 229173 [details] [diff] [review]
v1: use {moz:locale} for locale

lets go with this one

Comment 8

[Tony Chang (Google)]

Attachment: trunk patch

on trunk

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 229173 [details] [diff] [review]
v1: use {moz:locale} for locale

a=drivers. Please go ahead and land on the branch.

Why isn't the trunk also pointing to mozilla.org, btw?

Comment 10

[Tony Chang (Google)]

(In reply to comment #9)
> (From update of attachment 229173 [details] [diff] [review] [edit])
> a=drivers. Please go ahead and land on the branch.
> 
> Why isn't the trunk also pointing to mozilla.org, btw?

I didn't apply bug 344063 to trunk.  I can change the urls in this patch if you want trunk to point to the bonecho urls that we're using on branch (http://www.mozilla.org/projects/bonecho/anti-phishing/report_general/, etc).

Comment 11

[Tony Chang (Google)]

on branch