343898 - Hard coded strings in the prefs general panel

Status: RESOLVED FIXED

(Minimo Graveyard :: Minimo Front-End, defect)

Description

[Cédric Corazza]

Hi,
There are two hard coded strings in the prefs general pref panel :
Full Screen Enabled
Homebar Enabled
They shouldn't be.

Comment 1

[Cédric Corazza]

Attachment: l10n strings patch

This is my first code patch, so it is likely false ..

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 228452 [details] [diff] [review]
l10n strings patch

the second part in pane-general.xul is tab indented, spaces seems to be the style in that file

Comment 3

[Doug Turner (:dougt)]

cool.  checked in the patch (without the ws changes)

Checking in chrome/content/preferences/pane-general.xul;
/cvsroot/mozilla/minimo/chrome/content/preferences/pane-general.xul,v  <--  pane-general.xul
new revision: 1.6.2.6; previous revision: 1.6.2.5
done
Checking in locales/en-US/chrome/preferences.dtd;
/cvsroot/mozilla/minimo/locales/en-US/chrome/Attic/preferences.dtd,v  <--  preferences.dtd
new revision: 1.1.2.2; previous revision: 1.1.2.1
done

Comment 4

[Simon Paquet [:sipaq]]

Comment on attachment 228452 [details] [diff] [review]
l10n strings patch

Thias patch got checked in. Removing review request