344166 - Report phishing Website opens with middle click even when disabled

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Aiing]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 BonEcho/2.0b1

On a blank tab Middle mouse click on Help --> Report Phishing Website menu item opens the report phishing website page.

 

Reproducible: Always

Steps to Reproduce:
1. Open a blank tab
2. Open Help Menu
3. Middle click "Report Phishing Website" (greyed out)

Actual Results:  
Report phishing website page opens

Expected Results:  
Nothing happens

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 BonEcho/2.0b1 ID:2006071003

Comment 1

[Adam Kowalczyk]

Confirmed.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This isn't really a regression from bug 337484, checkForMiddleClick just doesn't check whether the node it's calling oncommand for is disabled. You can see the same bug if you middle click on a disabled back button, though it only throws so it's not nearly as noticeable.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

checkForMiddleClick is currently used on the following elements:
menuitem, menu, toolbarbutton, popup, menupopup

Of these, the disabled attribute only has an effect on the first three, but checking it for =="true" shouldn't hurt in the [menu]popup case.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 228782 [details] [diff] [review]
patch

r=mano if you file a bug on the menuitem binding only caliming to implement nsIDOMXULSelectControlElement
(I'm not sure if this is the right interface to implement, but we sure need the disabled property implemented when the attribute affects the element behavior).

Add a comment above the check referring to that bug.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I filed bug 344487.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/utilityOverlay.js 	1.39

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/utilityOverlay.js 	1.32.2.9