344369 - redesign label to specify control element directly

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[alexander :surkov (:asurkov)]

Now label uses @control attribute or query nsIDOMXULLabeledControlElement from parent element to determine control element. xforms:label (in xhtml content) underlines accesskey if xforms:label direct child of some control. We need add accesskey underlying for xforms controls in xul context. Here we cannot use @control attribute for these proposes and I guess xforms controls shouldn't implement nsIDOMXULLabeledControlElement.

If xul label will provide a way to specify control element directly then xforms label can be able to use it.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Actually there is the way is to override 'labeledControlElement' property. All I need is xul:label's click handler should use this property too.

Comment 2

[Neil Deakin]

Comment on attachment 253484 [details] [diff] [review]
patch

looks ok. generally, a second review isn't needed for simple patches like this

Comment 3

[alexander :surkov (:asurkov)]

Is there a chance to get this patch on 1.8 branch? Who can approve this?

Comment 4

[[e-mail]]

(In reply to comment #3)
>Who can approve this?
1.8 branch drivers, of course, via the approval1.8.1.3 flag.

Comment 5

[Neil Deakin]

I doubt it will get approved though, since it is just cleanup that doesn't change any behaviour. Why do you need this in 1.8 when you can just use a workaround?
  

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #5)
> I doubt it will get approved though, since it is just cleanup that doesn't
> change any behaviour. Why do you need this in 1.8 when you can just use a
> workaround?
> 
> 

I like to force xforms:label to use xul:label much more (I assume I will extend xforms label binding from xul:label binding and override 'labeledControlElement' property. So I need this for XForms since they should work on 1.8 and on trunk. What kind of workaround do you see?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Checked in to trunk

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 253484 [details] [diff] [review]
patch

Clearing approval request since xforms took another approach.