344409 - Change updater's name to not be lowercase, and be less generic

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Matthew (lilmatt) Willis]

When applying an update (ex: .mar), the updater application runs. On Mac OS X, it appears in the dock and in the application menu as "updater". 

We should at least fix the capitalization, and preferably make it something more recognizable as a legitimate process doing something the user wants.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - changes names

Changes display name to be "Mozilla Updater".
I didn't use MOZ_APP_NAME or an equivalent since things like "XULRunner Updater" could be confusing to an end user.

While "Mozilla" may be less familiar than say, "Firefox", it is far better than "updater" from a "what the crap is this scary thing running on my system for?!" Keep in mind that while this app is running, the updater.ini text is also displayed, which includes the app name.

Comment 2

[Matthew (lilmatt) Willis]

Since Bugzilla can't handle UTF-16, here's the ASCII version

/* Localized versions of Info.plist keys */

CFBundleName = "Mozilla Updater";
NSHumanReadableCopyright = "Copyright © 2005-2006 Mozilla Foundation";

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 229405 [details] [diff] [review]
rev0 - changes names

Even better might be "Mozilla Software Updater" since it's used to ... uhh ... update mozilla software.

Comment 4

[Matthew (lilmatt) Willis]

Attachment: rev1 - uses @MOZ_APP_DISPLAYNAME@

After chatting with mconnor, using MOZ_APP_DISPLAYNAME looks like the way to go instead. It gets us around messy trademark issues, and allows us to actually READ the file.

Comment 5

[Reed Loden [:reed]]

(In reply to comment #2)
> NSHumanReadableCopyright = "Copyright © 2005-2006 Mozilla Foundation";

Foundation or Corporation?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #5)
> Foundation or Corporation?

All IP belongs to the Foundation. All hail the Foundation!

Yeah, this looks good and better than what we have now.

Comment 7

[Matthew (lilmatt) Willis]

Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

Moving review over to bsmedberg per mconnor in irc

Comment 8

[Benjamin Smedberg]

Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

This isn't going to work with XULRunner, but we can punt on that for now.

Comment 9

[Matthew (lilmatt) Willis]

Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

Patch checked in on trunk.
Baking.

Comment 10

[Matthew (lilmatt) Willis]

Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

Looks happy on trunk. Requesting a181

Comment 11

[Reed Loden [:reed]]

Marking as FIXED, as the patch is on Trunk.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230535 [details] [diff] [review]
rev1 - uses @MOZ_APP_DISPLAYNAME@

a=beltzner on behalf of drivers for the mozilla_1_8_branch

Comment 13

[Matthew (lilmatt) Willis]

Patch landed on MOZILLA_1_8_BRANCH.

Comment 14

[Matthew (lilmatt) Willis]

Verified in update to BonEcho this morning...

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1

-> VERIFIED