344846 - Add UI to delete summary file from folder properties dialog

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David :Bienvenu]

There are enough situations where we tell the user to delete the .msf file that it's worth having UI for this in the folder properties dialog. Folder properties is more or less a power user feature anyway...

Comment 1

[David :Bienvenu]

Attachment: proposed fix

This adds a "Rebuild Summary File" button to the folder properties dialog and implements it. In implementing this, I also fixed the problem where some users inbox.msf files were getting regenerated every time they started up and the message counts were doubling.

I made setting a summary file as valid also commit the db, since you pretty much always want to do that, and if you forget, it can cause problems.

I would like to implement a non-destructive regeneration of summary files at some point, one which copies info from the old .msf file, instead of just deleting the .msf file and rebuilding/redownloading the headers. This could be hooked up to this UI, so users would do this instead of deleting the .msf files from their profile dir.

Comment 2

[Scott MacGregor]

Comment on attachment 229396 [details] [diff] [review]
proposed fix

I think we should call this "Rebuild" in the UI instead of Rebuild Summary File. I think that sounds more user friendly.

Comment 3

[David :Bienvenu]

fixed on trunk - will land on 2.0 branch after alpha.

Comment 4

[David :Bienvenu]

Comment on attachment 229396 [details] [diff] [review]
proposed fix

setting thunderbird2 flag so I won't forget this

Comment 5

[Mike Cowperthwaite]

Cool feature -- but contrary to comment 2, I find the "Rebuild" to be overly terse.  "Rebuild Index" would have been nicer, I think.

Comment 6

[David :Bienvenu]

I like Rebuild Index better as well. Scott?

Comment 7

[Scott MacGregor]

that works for me.

Comment 8

[David :Bienvenu]

Attachment: adopt Mike's suggestion

I'll check this in.  The tooltip will still say Rebuild Summary File, but I think that's ok - it's a little bit of extra info.

Comment 9

[David :Bienvenu]

Comment on attachment 232644 [details] [diff] [review]
adopt Mike's suggestion

patch checked in.

Comment 10

[David :Bienvenu]

Comment on attachment 229396 [details] [diff] [review]
proposed fix

clearing, already landed.