Closed Bug 344873 Opened 18 years ago Closed 18 years ago

Failure of PostCreate is not handled well

Categories

(Core :: XPConnect, defect, P1)

Product:
Core
Component:
XPConnect
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta2

People

(Reporter: bzbarsky, Assigned: mrbkap)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Fix
1.24 KB, patch
jst
: review+
brendan
: superreview+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
We should remove the XPCWrappedNative from the map when PostCreate fails.  That way we won't get the sort of "now it doesn't work, now it does" stuff bug 344830 reports.
Attached patch Fix — — Splinter Review 
This patch also fixes a refcounting botch introduced by the previous patch.
Assignee: dbradley → mrbkap
Status: NEW → ASSIGNED
Attachment #229576 - Flags: superreview?(brendan)
Attachment #229576 - Flags: review?(jst)
Comment on attachment 229576 [details] [diff] [review]
Fix

Sorry, I should have seen this one.

/be
Attachment #229576 - Flags: superreview?(brendan) → superreview+
Comment on attachment 229576 [details] [diff] [review]
Fix

r=jst
Attachment #229576 - Flags: review?(jst) → review+
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8.1beta2
Flags: blocking1.8.1?
Comment on attachment 229576 [details] [diff] [review]
Fix

Needed js1.7 landing followup fix.

/be
Attachment #229576 - Flags: approval1.8.1?
Comment on attachment 229576 [details] [diff] [review]
Fix

a=mconnor on behalf of drivers
Attachment #229576 - Flags: approval1.8.1? → approval1.8.1+
Flags: blocking1.8.1? → blocking1.8.1+
Whiteboard: [checkin needed (1.8 branch)]
Fixed on the 1.8 branch.
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Depends on: 364474
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: