Closed Bug 345471 Opened 18 years ago Closed 18 years ago

Help Window Icon Replacement

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: mglenn, Assigned: jgoldman)

References

(
URL
)

Details

(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])

Attachments

(4 files, 3 obsolete files)

Pinstripe image replacements v2
17.11 KB, application/octet-stream
Details
Winstripe Image Replacements
17.30 KB, application/octet-stream
Details
Pinstripe image replacements patch v3
6.88 KB, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review
Winstripe image replacement patch
8.16 KB, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
Update of the icon set for the help window.
Flags: blocking-firefox2+
Status: NEW → ASSIGNED
Whiteboard: [Fx2 theme change]
*** Bug 347920 has been marked as a duplicate of this bug. ***
Assignee: mglenn → jgoldman
Status: ASSIGNED → NEW
Requires the pinstripe-help-images.zip, which follows.
Attachment #233933 - Flags: review?(mconnor)
Attached file Pinstripe image replacements (obsolete) — 
Requires the previously uploaded help-icons.diff for Pinstripe
Looks fine here on my Mac.
Replaces the previous patch. This connects the dropmarks with the Back/Forward buttons as per the Main Window toolbar. There's still a problem with this patch as the Home and Print buttons shrink by 2 px when you hover which causes them to shift.
Attachment #233933 - Attachment is obsolete: true
Attachment #233933 - Flags: review?(mconnor)

        Attachment #233934 -
        Attachment is obsolete: true

    
    

    
  
Where are the Winstripe bits? :)

    
    

    
  


  
Requires the forthcoming winstripe patch file.

    
    

    
  


  
All known issues are resolved with this patch. Requires the pinstripe v3 images.zip.

        Attachment #233954 -
        Attachment is obsolete: true

        Attachment #234160 -
        Flags: review?(mconnor)

    
    

    
  


  

        Attachment #234162 -
        Flags: review?(mconnor)

    
    

    
  
Comment on attachment 234160 [details] [diff] [review]
Pinstripe image replacements patch v3

looks great

        Attachment #234160 -
        Flags: review?(mconnor)

        Attachment #234160 -
        Flags: review+

        Attachment #234160 -
        Flags: approval1.8.1+

    
    

    
  
Comment on attachment 234162 [details] [diff] [review]
Winstripe image replacement patch

this needed a couple extra lines to suppress some of the restored hover styles

will fix on checkin, otherwise looks good!

        Attachment #234162 -
        Flags: review?(mconnor)

        Attachment #234162 -
        Flags: review+

        Attachment #234162 -
        Flags: approval1.8.1+

    
    

    
  
landed on branch!
Keywords: fixed1.8.1

    
  
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: