3458 - ignoring right on inline elements

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There is one problem with combining horizontal relative positioning and margins
of inline elements.  It happens with both inline and replaced elements, so you
can see it in the last two tests (possibly four - I plan to expand the test a
little to help isolate the problem) of these two pages:

non-replaced: http://www.fas.harvard.edu/~dbaron/csstest/sec100301
replaced: http://www.fas.harvard.edu/~dbaron/csstest/sec100302

The problem is that
right: -10px;
margin-right: 20px;

puts all 20px of space on the right side of the element, rather than 10px on
each side.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For the non-replaced elements, the problem is simply that you are ignoring
"right" altogether.  If left is auto, then left:=-right, otherwise right := -
left (per CSS2 errata).  I should add a simple "right" test.

For the replaced elements, the problem seems as I described it before, and
therefore shows on all four tests at the end.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Whoops... typo in the tests (forgot to change the class="" on the second
test!).  The problem is now much simpler:

You are ignoring right on inline elements.  Fix is as described for non-
replaced elements in my previous comment.  Retitling bug to "ignoring right on
inline elements" (from "horizontal relative positioning and margins of inline
elements")

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This seems to have been fixed.

Comment 4

[kipp]

Fixed during recent line-layout/inline-reflow rework. The values computed by the
html-reflow-state (thanks troy!) work dandy.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Verified fixed.