345908 - Search engine update system is leaking nsXPCWrappedJS and XPCWrappedNative objects

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Adam Guthrie]

In bug 345530 we tracked down one of the leaks to the search engine update system landing. See bug 345530 comment 0 for leak numbers.

I heard Gavin and Joey say something about timers in the update system... maybe those are related.

Comment 1

[Adam Guthrie]

*** Bug 345530 has been marked as a duplicate of this bug. ***

Comment 2

[Joey Minta]

What about pulling the timeout registration outside of the object implementing the callback?  I'm just guessing here, but that seems to be the most reasonable way we could leak here.
http://lxr.mozilla.org/seamonkey/source/browser/components/search/nsSearchService.js#2858

Comment 3

[Adam Guthrie]

Joey, could you make a patch that does what you mentioned in comment 2? I'd be willing to test it and report back as to whether it fixes the leaks or not.

Comment 4

[Joey Minta]

Attachment: shot in the dark

Adam, this is the patch that I was describing.

Comment 5

[Adam Guthrie]

Comment on attachment 233682 [details] [diff] [review]
shot in the dark

Unfortunately, this doesn't seem to fix the leaks. 

FWIW, earlier today (before I commented here) I commented out the entire engineUpdateService var and the everything that referenced it; e.g. SearchService._init() and this fixed the leaks.

Comment 6

[Robert Strong (they/them - no direct email)]

I suspect that the patch in bug 349379 will fix this.

Comment 7

[Adam Guthrie]

Fixed by bug 349379.