346143 - Tabs Need Visual Finesse

Status: RESOLVED WONTFIX

(Camino Graveyard :: Tabbed Browsing, enhancement)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The tabs look kinda weird around the close button/favicon cluster. 

Not sure what the right approach is but this should look neater somehow. Consult a visual designer?

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

As I recall, we discussed this extensively when the new tabs were under development.  It may look odd, but it's 100% stable and consistent; nothing ever jumps around.

BTW, Fx 2.0b1 also has this config by default with a reasonable number of tabs, so maybe I'm missing what you find weird...?

Comment 2

[Samuel Sidler (old account; do not CC)]

I've always thought the close buttons didn't look right, but not enough to matter. Ben, what exactly looks weird to you? Mike, maybe you have an idea?

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Hmm, Wevah has a bug somewhere on the close buttons moving or something to that effect, and of course there's the bug about the site icons being 1-2px too small.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

I would understand completely if you marked this "invalid"... here are the things I found weird:

- there was a lot of space around the close button/favicon elements... and they weren't always the same size
- the background tabs don't really look like tabs, more like static controls - the only thing that sets them apart from the tabstrip gutter is the close button/edging. 
- I wonder if they would look better if the background of the tabstrip blended up into the unified toolbar and had less of a pinstripe. 

Don't get me wrong, I think they look better than the excessively rounded corners on Firefox's tabs. 

Comment 5

[Samuel Sidler (old account; do not CC)]

(In reply to comment #4)
> - I wonder if they would look better if the background of the tabstrip blended
> up into the unified toolbar and had less of a pinstripe. 

The only issue with this is keeping the tabs themable (which they are now) while still making them look good on both 10.3 and 10.4+. If we ship tabs that are 10.4-centric, they'll look weird on 10.3. We can do an ifdef (or whatever) to check for 10.4 and otherwise show the current style, but then we have to ship two different styles of themes.

Comment 6

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]