Closed Bug 346245 Opened 18 years ago Closed 18 years ago

attribute parameter 'johndoe@company.tld' is not a hash ref at Bugzilla/Auth/Verify.pm line 112

Categories

(Bugzilla :: User Accounts, defect)

Product:
Bugzilla
Component:
User Accounts
Version:
2.23
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.0

People

(Reporter: Wurblzap, Assigned: mkanat)

References

Details

Attachments

(1 file)

v1
1.12 KB, patch
Wurblzap
: review+
Details | Diff | Splinter Review 
If I log in to Bugzilla using a different case for my login than what's in the database (eg. johndoe@company.tld instead of the current profiles table entry JohnDoe@company.tld), I get "DBI::db=HASH(0x22058a8)->do(...): attribute parameter 'johndoe@company.tld' is not a hash ref at Bugzilla/Auth/Verify.pm line 112."

This is because two things are amiss in Bugzilla/Auth/Verify.pm:
Firstly, it needs to ignore the case when comparing logins here:

    # Now that we have a valid User, we need to see if any data has to be
    # updated.
    if ($username && $user->login ne $username) {

Secondly, it needs to supply undef to $dbh->do a couple of lines further down.
Summary: attribute parameter 'mschumann@inconso.de' is not a hash ref at Bugzilla/Auth/Verify.pm line 112 → attribute parameter 'johndoe@company.tld' is not a hash ref at Bugzilla/Auth/Verify.pm line 112
Ah, yes, that definitely needs to be fixed. Patch coming up.
Assignee: user-accounts → mkanat
Attached patch v1 — — Splinter Review 
Thank you, Marc! That also explains how sometimes we were reaching that segment of code when it *really* should not have been reached.
Attachment #231064 - Flags: review?(wurblzap)
Status: NEW → ASSIGNED
Attachment #231064 - Flags: review?(wurblzap) → review+
Flags: approval?
Flags: approval? → approval+
Checking in Bugzilla/Auth/Verify.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Verify.pm,v  <--  Verify.pm
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
*** Bug 353521 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: