346259 - [FIX]Forward button can load a page in the wrong frame

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[dolphinling]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060727 Minefield/3.0a1 ID:2006072710 

Go to http://talkback-public.mozilla.org/reports/firefox/ . Click Firefox 2 Branch, then Simple Reports -> All Platforms (on the left). Hit back twice, then forward twice. The page loads in the wrong frame.

This happens in trunk builds starting sometime before 2006-06-21, but not in 1.8.1 builds (better regression range coming).

Comment 1

[dolphinling]

Regressed between 2006-02-22 and 02-23

Comment 2

[dolphinling]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=notregexp&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-02-22&maxdate=2006-02-23+04&cvsroot=%2Fcvsroot
Bonsai link

I should have mentioned earlier, this bug was filed for timeless, who originally found it.

Also, disabling fastback does not fix the bug.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Looks like a regression from the second patch for bug 305181.  :(  I'll look into it, I guess...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Subframe for testcase

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 6

[Boris Zbarsky [:bzbarsky]]

So it looks like the issue is that when we go back the second time we destroy the two child docshells, which removes the corresponding SHEntries from the parent's SHEntry... which is probably wrong in this case.

bryner, any idea how we can make this consistent?  Should I just back out the additional patch for bug 305181?

Comment 7

[Brian Ryner (not reading)]

(In reply to comment #6)
> So it looks like the issue is that when we go back the second time we destroy
> the two child docshells, which removes the corresponding SHEntries from the
> parent's SHEntry... which is probably wrong in this case.
> 
> bryner, any idea how we can make this consistent?  Should I just back out the
> additional patch for bug 305181?
> 

It's up to you, I don't really have time to analyze the session history interaction.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Backout

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.