346263 - While changing account settings for an IMAP mail account, I was not allowed to change the case of either the username or servername

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Andrew Kositsky]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Thunderbird/version 1.5.0.5 (20060719)

While changing account settings for an IMAP mail account, I was not allowed to change the case of either the username or servername.

I got an error message

"An account with that user name and server name already exists. Please enter a different user name and/or server name."

even though I was changing the account to which the error message is refering.  If I change the server or user name (say by putting in an extra letter,) I can then change back to the original server or user name in whatever case I want.

Reproducible: Always

Steps to Reproduce:
1. set up a new IMAP mail account with some arbitrary user name and server name (e.g. user name = bob, server name = incoming mail server = foo.bar.com)
2. Close account settings (this step may or may not be necessary; saving may be all that is necessary.)
3. reopen account settings, go to server settings on the account in question
4. try to change Server Name from "foo.bar.com" to "Foo.bar.com"

Actual Results:  
I received the error:
"An account with that user name and server name already exists. Please enter a different user name and/or server name."

Expected Results:  
The software should allow changing the case of server names.

standard installation of windows XP, default everything in Thunderbird (as for as I know)

Comment 1

[Nikolay Shopik]

exist on version 3.0a1pre (2008040903)

Comment 2

[:aceman]

Interestingly, if you change case of both server and username, that change will be allowed.

There is a check to disallow setting server+user combination to the same combination existing in other account. But in the report it looks like the combination in one account is colliding with itself. I'll look into this.

Comment 3

[:aceman]

Attachment: patch

This should do it. No visual changes intended.

Comment 4

[Ian Neal]

Comment on attachment 619452 [details] [diff] [review]
patch

On code inspection only, no testing as yet.
>+      let changeText = "";
>+      if ((oldHost != newHost) &&
>+          (filterList != undefined) && filterList.filterCount)
>+        changeText = prefBundle.getString("serverNameChanged");
>       if (oldUser != newUser)
>+        changeText = changeText + "\n\n" + prefBundle.getString("userNameChanged");
Don't you need to check that changeText is not "" before adding "\n\n" otherwise your alert will have two new lines at the beginning?

Comment 5

[:aceman]

There were tons of checks before but I found them superfluous.
The .trim will take care of the leading newlines.

Comment 6

[Ian Neal]

(In reply to :aceman from comment #5)
> There were tons of checks before but I found them superfluous.
> The .trim will take care of the leading newlines.

Sorry, I missed that last change.
I believe it should be changeText.trim() not String.trim(changeText)

Comment 7

[:aceman]

Attachment: patch v2

Both ways seem to work.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 620476 [details] [diff] [review]
patch v2

Review of attachment 620476 [details] [diff] [review]:
-----------------------------------------------------------------

Just two nits - but otherwise, from inspection, this looks good.

Great work, as usual.

::: mailnews/base/prefs/content/AccountManager.js
@@ +259,5 @@
> + * Check if the user and/or host names have been changed and if so check
> + * if the new names already exists for an account or are empty.
> + * Also check if the Local Directory path was changed.
> + *
> + * @param showAlert  show and alert if any problem with server/user name is found?

I think I'd prefer this @param def'n to be:

show an alert if a problem with the host / user name is found.

@@ +360,1 @@
>  

Let's put a comment here saying that any extraneous whitespace will be trimmed off before showing the message.

Comment 9

[:aceman]

Attachment: patch v3

Thanks, done.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/81a3ad828425