346888 - Help Section "Using Bon Echo" -> "Searching" contains old-look Search Bar image

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Maxim Radugin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060801 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060801 BonEcho/2.0b1

Help Section "Using Bon Echo" -> "Searching" contains old-look Search Bar image from Firefox 1.5.x.x.

Reproducible: Always

Steps to Reproduce:
1. Open Firefox help.
2. Select Using Bon Echo -> Searching

Actual Results:  
Contains old-look Search Bar image

Expected Results:  
Should contain new Search Bar image

Comment 1

[Steffen Wilberg]

We need either a new screenshot or remove it. Note that the UI isn't final yet.

Comment 2

[Maxim Radugin]

Attachment: Firefox2 Search bar

Comment 3

[Steffen Wilberg]

Thanks, but that's only the current state. Bug 345407 will make further changes to the searchbar.

Comment 4

[Maxim Radugin]

Attachment: Firefox2 Search bar

Since bug 345407 is fixed, this one is the final search-bar look

Comment 5

[Axel Hecht [:Pike]]

Requesting blocking to get this either on the radar and landed or off my radar.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Axel, why is this on your radar? Do we need new images for all the locales to properly capture the default search engine for each locale? Or is this a straight one-time image replacement

Comment 7

[Axel Hecht [:Pike]]

Any help change is on my radar, and for CJKT builds, we may want to use a Yahoo screenshot. All others should actually be fine with a google one.

Comment 8

[Mike Connor [:mconnor]]

This needs to be updated at http://www.mozilla.org/projects/firefox/help/1.1/searchbar.png

This is a web-hosted image, and thus can be replaced after freeze.

Comment 9

[Jeff Walden (gone starting June 8)]

(In reply to comment #8)
> This is a web-hosted image, and thus can be replaced after freeze.

Not quite; the image is (as its name might slightly indicate) used in Firefox 1.5 as well, so we should really change the URL so 1.5 builds don't start having a funky search bar image.

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: URL change

Per comment 9, here's a patch that changes the URL to one which identifies the default search engine in the en-US locale (for en-US, that's searchbar-google.png).  Other locales can leave this as is or change it to reflect their default search engine, as needed (i.e. we can create a searchbar-yahoo.png for CJKT builds).

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 238368 [details] [diff] [review]
patch v1: URL change

not the right fix, we're going to change the baseURL, we've already copied the content over, and will update that content before ship

Comment 12

[Mike Connor [:mconnor]]

Attachment: change the baseURL

turns out, we only have a couple of images that we use (searchbar and urlbar) but its better and cleaner to do this anyway!

Comment 13

[Mike Schroepfer]

Should this be .org vs .com?

Comment 14

[Mike Connor [:mconnor]]

updated content is checked in, will be live soon.

Comment 15

[Mike Connor [:mconnor]]

(In reply to comment #13)
> Should this be .org vs .com?
> 

Not at this point, its not specific to branded builds, and the rest of the remote help content is there.  We don't currently have a home for Help yet, when we do we can redirect tehre.

Comment 16

[Mike Schroepfer]

Comment on attachment 238452 [details] [diff] [review]
change the baseURL

a=schrep

Comment 17

[Mike Connor [:mconnor]]

new images are live, landed branch and trunk

Comment 18

[Axel Hecht [:Pike]]

Post to .l10n to alert localizers?

For those locales that use en-US screenshots, this has late-l10n impact, for those locales that ship localized screenshots in ab-CD.jar, it must not. Thus we can't easily cover this change.