Closed Bug 346914 Opened 18 years ago Closed 12 years ago

Infallible JS_SetPrivate

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: igor, Unassigned)

Details

[This is a spin-off of bug 346450 comment 14 , 15 , 16]

Currently many users of JS_SetPrivate check for possible failure of JS_SetPrivate. But this function is infallible so such checks are unnecessary. We should remove such checks and either fix JS_SetPrivate so it would return void or at least document that the function always returns true if backward compatibility issues can not be addressed with preprocessor hacks or something.
Already done.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.