347078 - [SessionStore] Correctly JSON-ify the API

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[Simon Bünzli]

Until bug 340987 gets fixed (which would make this dead-simple), we should probably fall back on using Douglas Crockford's toJSONString/parseJSON methods from http://www.json.org/json.js .

Comment 1

[Dietrich Ayala (:dietrich)]

Requesting blocking, as bug 344640 can't move forward until this is addressed.

Comment 2

[Simon Bünzli]

Note that there is already a fully JSON-compliant patch attached to bug 344640 so this bug might get unnecessary soon.

Comment 3

[Dietrich Ayala (:dietrich)]

(In reply to comment #2)
> Note that there is already a fully JSON-compliant patch attached to bug 344640
> so this bug might get unnecessary soon.
> 

Shaver is saying that evalInSandbox is not sufficient, and that we should use the json.org code in favor of it. The patch to bug 344640 is still using evalInSandbox.

Comment 4

[Simon Bünzli]

> Shaver is saying that evalInSandbox is not sufficient, and that we should use
> the json.org code in favor of it. The patch to bug 344640 is still using
> evalInSandbox.

If evalInSandbox isn't enough, we'll have to change the file format again. Anyway, I prefer having that discussion over in bug 344640.